linux-kernel - Re: [PATCH] tty: n_gsm: delete SABM command frame as requester

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <695b2537-28e0-90c4-d516-727dfeead12d@kernel.org>
Date:   Thu, 1 Jul 2021 08:13:25 +0200
From:   Jiri Slaby <jirislaby@...nel.org>
To:     Zhenguo Zhao <zhenguo6858@...il.com>, gregkh@...uxfoundation.org
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tty: n_gsm: delete SABM command frame as requester

On 01. 07. 21, 4:54, Zhenguo Zhao wrote:
> From: Zhenguo Zhao <Zhenguo.Zhao1@...soc.com>
> 
> as initiator,it need to send SABM conmmand ,as requester,there is
> no need to send the SABM control frame,it will cause redundant data.

Hi,

is there any document you can refer to? I am still confused so I don't 
understand why this didn't matter until now. Maybe you only need to 
explain better the whole point behind the introduced initiator/requester 
functionality.

In any way, could you use spell checker on the commit log (like "conmmand")?

> Signed-off-by: Zhenguo Zhao <Zhenguo.Zhao1@...soc.com>
> ---
>   drivers/tty/n_gsm.c | 5 +++--
>   1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/tty/n_gsm.c b/drivers/tty/n_gsm.c
> index 5fea02c..e66418b 100644
> --- a/drivers/tty/n_gsm.c
> +++ b/drivers/tty/n_gsm.c
> @@ -3005,8 +3005,9 @@ static int gsmtty_open(struct tty_struct *tty, struct file *filp)
>   	/* We could in theory open and close before we wait - eg if we get
>   	   a DM straight back. This is ok as that will have caused a hangup */
>   	tty_port_set_initialized(port, 1);
> -	/* Start sending off SABM messages */
> -	gsm_dlci_begin_open(dlci);
> +	/* Start sending off SABM messages for initiator */
> +	if (gsm->initiator)
> +		gsm_dlci_begin_open(dlci);
>   	/* And wait for virtual carrier */
>   	return tty_port_block_til_ready(port, tty, filp);
>   }
> 

thanks,
-- 
js
suse labs