linux-kernel - Re: nios2-linux-ld: atmel-isc-base.c:undefined reference to `__this

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <be5820da-19a6-7119-94d3-46a1ac3b83c8@microchip.com>
Date:   Thu, 1 Jul 2021 10:06:52 +0000
From:   <Eugen.Hristev@...rochip.com>
To:     <hverkuil@...all.nl>
CC:     <lkp@...el.com>, <kbuild-all@...ts.01.org>,
        <linux-kernel@...r.kernel.org>, <mchehab@...nel.org>,
        <linux-media@...r.kernel.org>
Subject: Re: nios2-linux-ld: atmel-isc-base.c:undefined reference to
 `__this_module'

On 6/30/21 10:34 AM, kernel test robot wrote:

> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head:   007b350a58754a93ca9fe50c498cc27780171153
> commit: c9aa973884a163ecb6d5d4d3be9137058adcaf8c media: atmel: atmel-isc: add microchip-xisc driver
> date:   3 weeks ago
> config: nios2-randconfig-r035-20210630 (attached as .config)
> compiler: nios2-linux-gcc (GCC) 9.3.0
> reproduce (this is a W=1 build):
>          wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>          chmod +x ~/bin/make.cross
>          # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=c9aa973884a163ecb6d5d4d3be9137058adcaf8c
>          git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
>          git fetch --no-tags linus master
>          git checkout c9aa973884a163ecb6d5d4d3be9137058adcaf8c
>          # save the attached .config to linux build tree
>          mkdir build_dir
>          COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross O=build_dir ARCH=nios2 SHELL=/bin/bash
> 
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@...el.com>
> 
> All errors (new ones prefixed by >>):
> 
>     nios2-linux-ld: drivers/media/platform/atmel/atmel-isc-base.o: in function `isc_async_complete':
>     atmel-isc-base.c:(.text+0x279c): undefined reference to `__this_module'
>>> nios2-linux-ld: atmel-isc-base.c:(.text+0x27c4): undefined reference to `__this_module'
>>> nios2-linux-ld: drivers/media/platform/atmel/atmel-isc-base.o:(.rodata+0x414): undefined reference to `__this_module'
>>> nios2-linux-ld: drivers/media/platform/atmel/atmel-isc-base.o:(__param+0x4): undefined reference to `__this_module'
>     nios2-linux-ld: drivers/media/platform/atmel/atmel-isc-base.o:(__param+0x18): undefined reference to `__this_module'
> 
> ---
> 0-DAY CI Kernel Test Service, Intel Corporation
> https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
> 


Hello Hans,

Could you please help me to solve this ?
The cause is that both the XISC and the ISC have the common file 
atmel-isc-base.c and building one as a module and the other as built-in 
is problematic , as atmel-isc-base.o is only built once.
One solution is to enforce the other as a module if one of them is 
selected as a module. Do you know how I can do that ?

Thanks,
Eugen