linux-kernel - Re: [PATCH 1/4] arm64: dts: rockchip: helios64: fixup USB setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 1 Jul 2021 15:35:44 +0200
From:   Uwe Kleine-König <uwe@...ine-koenig.org>
To:     Dennis Gilmore <dgilmore@...hat.com>,
        linux-rockchip@...ts.infradead.org
Cc:     Rob Herring <robh+dt@...nel.org>, Heiko Stuebner <heiko@...ech.de>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        "moderated list:ARM/Rockchip SoC support" 
        <linux-arm-kernel@...ts.infradead.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/4] arm64: dts: rockchip: helios64: fixup USB setup

Hello Dennis,

On 7/1/21 2:59 PM, Dennis Gilmore wrote:
> On Thu, 2021-07-01 at 11:31 +0200, Uwe Kleine-König wrote:
>> Hello,
>>
>> On 7/1/21 2:40 AM, Dennis Gilmore wrote:
>>> Without the usbdrd_dwc3_1 node defined u-boot will throw an error
>>> and
>>> reset the system.
>>
>> I wonder if this should better be fixed in u-boot then?!
>>
>>> All other rk3399 systems use this format
>>
>> This is true for the dwc nodes, however for the usb2 nodes there are
>> several that use this idiom (and even repeat the label name), see for
>> example the &u2phy0 node in
>> arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dtsi .
>>
> 
> looking at that file is where I got the idea to set it up as I have
> proposed, it follows the format I have submitted

I guess you didn't read exactly what I wrote and only looked at &usbdrd* 
but not &u2phy0.

Best regards
Uwe



Download attachment "OpenPGP_signature" of type "application/pgp-signature" (489 bytes)