linux-kernel - Re: [PATCH v6 4/6] soc: qcom: Add support for Core Power Reduction v3, v4 and Hardened

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 1 Jul 2021 21:52:18 +0800
From:   kernel test robot <lkp@...el.com>
To:     AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...ainline.org>,
        bjorn.andersson@...aro.org
Cc:     kbuild-all@...ts.01.org, agross@...nel.org, robh+dt@...nel.org,
        lgirdwood@...il.com, broonie@...nel.org,
        linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, phone-devel@...r.kernel.org,
        konrad.dybcio@...ainline.org
Subject: Re: [PATCH v6 4/6] soc: qcom: Add support for Core Power Reduction
 v3, v4 and Hardened

Hi AngeloGioacchino,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on robh/for-next]
[also build test WARNING on linus/master v5.13 next-20210701]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/AngeloGioacchino-Del-Regno/Add-support-for-Core-Power-Reduction-v3-v4-and-Hardened/20210701-185521
base:   https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
config: arm64-allyesconfig (attached as .config)
compiler: aarch64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/2abd8addac7695342f7d6de0c4ceac55dd60ea43
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review AngeloGioacchino-Del-Regno/Add-support-for-Core-Power-Reduction-v3-v4-and-Hardened/20210701-185521
        git checkout 2abd8addac7695342f7d6de0c4ceac55dd60ea43
        # save the attached .config to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross O=build_dir ARCH=arm64 SHELL=/bin/bash drivers/soc/qcom/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   drivers/soc/qcom/cpr3.c:355: warning: Function parameter or member 'tdesc' not described in 'cpr_get_ro_factor'
   drivers/soc/qcom/cpr3.c:355: warning: Function parameter or member 'fnum' not described in 'cpr_get_ro_factor'
   drivers/soc/qcom/cpr3.c:355: warning: Function parameter or member 'ro_idx' not described in 'cpr_get_ro_factor'
   drivers/soc/qcom/cpr3.c:558: warning: Function parameter or member 'drv' not described in 'cpr_set_acc'
   drivers/soc/qcom/cpr3.c:558: warning: Excess function parameter 'thread' description in 'cpr_set_acc'
>> drivers/soc/qcom/cpr3.c:581: warning: expecting prototype for cpr_post_voltage(). Prototype was for cpr_pre_voltage() instead
   drivers/soc/qcom/cpr3.c:1145: warning: Function parameter or member 'ring_osc_factor' not described in 'cpr3_adjust_quot'
   drivers/soc/qcom/cpr3.c:1145: warning: Function parameter or member 'volt_closed_loop' not described in 'cpr3_adjust_quot'
   drivers/soc/qcom/cpr3.c:1145: warning: Excess function parameter 'thread' description in 'cpr3_adjust_quot'


vim +581 drivers/soc/qcom/cpr3.c

   569	
   570	/**
   571	 * cpr_post_voltage() - Actions to execute before setting voltage
   572	 * @thread:     Structure holding CPR thread-specific parameters
   573	 * @dir:        Enumeration for voltage change direction
   574	 * @fuse_level: Fuse corner for mem-acc, if supported.
   575	 *
   576	 * Return: Zero for success or negative number on errors.
   577	 */
   578	static int cpr_pre_voltage(struct cpr_thread *thread,
   579				   enum voltage_change_dir dir,
   580				   int fuse_level)
 > 581	{
   582		struct cpr_drv *drv = thread->drv;
   583	
   584		if (drv->desc->cpr_type == CTRL_TYPE_CPR3 &&
   585		    drv->desc->pd_throttle_val)
   586			cpr_write(thread, CPR3_REG_PD_THROTTLE,
   587				  drv->desc->pd_throttle_val);
   588	
   589		if (drv->tcsr && dir == DOWN)
   590			cpr_set_acc(drv, fuse_level);
   591	
   592		return 0;
   593	}
   594	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (77637 bytes)