linux-kernel - Re: [PATCH 2/2] tracing: Resize tgid_map to PID_MAX_LIMIT, not PID_MAX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210701095525.400839d3@oasis.local.home>
Date:   Thu, 1 Jul 2021 09:55:25 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Joel Fernandes <joelaf@...gle.com>
Cc:     Paul Burton <paulburton@...gle.com>, linux-kernel@...r.kernel.org,
        Ingo Molnar <mingo@...hat.com>, stable@...r.kernel.org
Subject: Re: [PATCH 2/2] tracing: Resize tgid_map to PID_MAX_LIMIT, not
 PID_MAX_DEFAULT

On Wed, 30 Jun 2021 19:11:45 -0400
Steven Rostedt <rostedt@...dmis.org> wrote:

> On Wed, 30 Jun 2021 18:34:11 -0400
> Joel Fernandes <joelaf@...gle.com> wrote:
> 
> > > Anyway, I'll wait to hear what Joel says on this. If he thinks this is
> > > worth 16M of memory when enabled, I may take it.    
> > 
> > I am not a huge fan of the 16M, in Android we enable this feature on
> > all devices. Low end Android devices traced in the field are sometimes
> > 1 GB and the added memory pressure may be unwelcome. Very least, maybe
> > make it optional only for folks who increase pid_max?  
> 
> Yeah, can we just set it to the size of pid_max, at whatever it is set
> to?

Can you send a V2 with this update and address Joel's comments to patch 1,
and get it to me today? I plan on sending Linus a pull request
tomorrow, which means I have to kick off my tests tonight for what I
want to send.

-- Steve