linux-kernel - Re: [PATCH v3 1/2] bus: mhi: Fix pm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1625104231.10055.19.camel@codeaurora.org>
Date:   Wed, 30 Jun 2021 18:50:31 -0700
From:   Hemant Kumar <hemantk@...eaurora.org>
To:     Paul Davey <paul.davey@...iedtelesis.co.nz>,
        Manivannan Sadhasivam <mani@...nel.org>
Cc:     Bhaumik Bhatt <bbhatt@...eaurora.org>,
        linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 1/2] bus: mhi: Fix pm_state conversion to string

On Tue, 2021-06-29 at 15:53 +1200, Paul Davey wrote:
> On big endian architectures the mhi debugfs files which report pm
> state
> give "Invalid State" for all states.  This is caused by using
> find_last_bit which takes an unsigned long* while the state is passed
> in
> as an enum mhi_pm_state which will be of int size.
> 
> Fix by using __fls to pass the value of state instead of
> find_last_bit.
> 
> Signed-off-by: Paul Davey <paul.davey@...iedtelesis.co.nz>

Reviewed-by: Hemant Kumar <hemantk@...eaurora.org>
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project