linux-kernel - Re: [PATCH v8 01/22] perf record: Introduce thread affinity and mmap masks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YN3P1uHBkh7JXBDN@kernel.org>
Date:   Thu, 1 Jul 2021 11:23:18 -0300
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     "Bayduraev, Alexey V" <alexey.v.bayduraev@...ux.intel.com>
Cc:     Jiri Olsa <jolsa@...hat.com>, Namhyung Kim <namhyung@...nel.org>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Andi Kleen <ak@...ux.intel.com>,
        Adrian Hunter <adrian.hunter@...el.com>,
        Alexander Antonov <alexander.antonov@...ux.intel.com>,
        Alexei Budankov <abudankov@...wei.com>,
        Riccardo Mancini <rickyman7@...il.com>
Subject: Re: [PATCH v8 01/22] perf record: Introduce thread affinity and mmap
 masks

Em Thu, Jul 01, 2021 at 04:05:09PM +0300, Bayduraev, Alexey V escreveu:
> Hi,
> 
> On 30.06.2021 19:17, Arnaldo Carvalho de Melo wrote:
> > Em Wed, Jun 30, 2021 at 06:54:40PM +0300, Alexey Bayduraev escreveu:
> [SNIP]
> >> +static void record__mmap_cpu_mask_free(struct mmap_cpu_mask *mask)
> >> +{
> >> +	bitmap_free(mask->bits);
> >> +	mask->nbits = 0;
> > 
> > Plese use NULL, as 'mask->nbits' is a pointer.
> 
> In perf/util/mmap.h "nbits" is size_t:
> 
> struct mmap_cpu_mask {
>         unsigned long *bits;
>         size_t nbits;
> };

My bad, I saw the pattern of:

    *_free(mask->bits);
    mask->bits = 0;

Nevermind :-)

- Arnaldo