linux-kernel - Re: [PATCH] perf intel-pt: Add a config for max loops without consuming a packet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aaf79640-4882-310a-e1e1-67f7818e82a0@linux.intel.com>
Date:   Thu, 1 Jul 2021 10:54:53 -0700
From:   Andi Kleen <ak@...ux.intel.com>
To:     Adrian Hunter <adrian.hunter@...el.com>,
        Arnaldo Carvalho de Melo <acme@...nel.org>
Cc:     Jiri Olsa <jolsa@...hat.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] perf intel-pt: Add a config for max loops without
 consuming a packet


On 7/1/2021 10:51 AM, Adrian Hunter wrote:
> The Intel PT decoder limits the number of unconditional branches (e.g.
> jmps) decoded without consuming any trace packets. Generally, a loop
> needs a conditional branch which generates a TNT packet, whereas a
> "ret" instruction will generate a TIP or TNT packet. So exceeding
> the limit is assumed to be a never-ending loop, which can happen if
> there has been a decoding error putting the decoder at the wrong place in
> the code.
>
> Up until now, the limit of 10000 has been enough but some analytic
> purposes have been reported to exceed that.
>
> Increase the limit to 100000, and make it configurable via perf config
> intel-pt.max-loops. Also amend the "Never-ending loop" message to
> mention the configuration entry.
>
> Signed-off-by: Adrian Hunter <adrian.hunter@...el.com>


Thanks. That is useful.


Reviewed-by: Andi Kleen <ak@...ux.intel.com>


-Andi