linux-kernel - Re: [PATCH 2/4] interconnect: Always call pre

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <000574efe90897c1738299cfba4fea7d@codeaurora.org>
Date:   Fri, 02 Jul 2021 00:25:04 +0530
From:   okukatla@...eaurora.org
To:     Mike Tipton <mdtipton@...eaurora.org>
Cc:     djakov@...nel.org, bjorn.andersson@...aro.org, agross@...nel.org,
        saravanak@...gle.com, linux-arm-msm@...r.kernel.org,
        linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org,
        mdtipton=codeaurora.org@...eaurora.org
Subject: Re: [PATCH 2/4] interconnect: Always call pre_aggregate before
 aggregate

On 2021-06-26 02:58, Mike Tipton wrote:
> The pre_aggregate callback isn't called in all cases before calling
> aggregate. Add the missing calls so providers can rely on consistent
> framework behavior.
> 
> Fixes: d3703b3e255f ("interconnect: Aggregate before setting initial 
> bandwidth")
> Signed-off-by: Mike Tipton <mdtipton@...eaurora.org>
> ---
>  drivers/interconnect/core.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/interconnect/core.c b/drivers/interconnect/core.c
> index 945121e18b5c..cfd54c90a6bb 100644
> --- a/drivers/interconnect/core.c
> +++ b/drivers/interconnect/core.c
> @@ -973,9 +973,12 @@ void icc_node_add(struct icc_node *node, struct
> icc_provider *provider)
>  	}
>  	node->avg_bw = node->init_avg;
>  	node->peak_bw = node->init_peak;
> -	if (provider->aggregate)
> +	if (provider->aggregate) {
> +		if (provider->pre_aggregate)
> +			provider->pre_aggregate(node);
nit: we can invoke pre_aggregate() out side of if (qcom_icc_aggregate).

>  		provider->aggregate(node, 0, node->init_avg, node->init_peak,
>  				    &node->avg_bw, &node->peak_bw);
> +	}
>  	provider->set(node, node);
>  	node->avg_bw = 0;
>  	node->peak_bw = 0;