linux-kernel - Re: [PATCH net-next v1 1/1] net: usb: asix: ax88772: suspend PHY on driver probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <931f10ca-2d81-8264-950c-8d29c18a7b35@gmail.com>
Date:   Thu, 1 Jul 2021 12:01:04 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Oleksij Rempel <o.rempel@...gutronix.de>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, Andrew Lunn <andrew@...n.ch>,
        Heiner Kallweit <hkallweit1@...il.com>,
        Russell King <linux@...linux.org.uk>
Cc:     Marek Szyprowski <m.szyprowski@...sung.com>, kernel@...gutronix.de,
        linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org,
        netdev@...r.kernel.org
Subject: Re: [PATCH net-next v1 1/1] net: usb: asix: ax88772: suspend PHY on
 driver probe

On 6/28/21 9:43 PM, Oleksij Rempel wrote:
> After probe/bind sequence is the PHY in active state, even if interface
> is stopped. As result, on some systems like Samsung Exynos5250 SoC based Arndale
> board, the ASIX PHY will be able to negotiate the link but fail to
> transmit the data.
> 
> To handle it, suspend the PHY on probe.

Very unusual, could not the PHY be attached/connected to a ndo_open()
time like what most drivers do?

> 
> Fixes: e532a096be0e ("net: usb: asix: ax88772: add phylib support")
> Signed-off-by: Oleksij Rempel <o.rempel@...gutronix.de>
> Reported-by: Marek Szyprowski <m.szyprowski@...sung.com>
> Tested-by: Marek Szyprowski <m.szyprowski@...sung.com>
> ---
>  drivers/net/usb/asix_devices.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/usb/asix_devices.c b/drivers/net/usb/asix_devices.c
> index aec97b021a73..2c115216420a 100644
> --- a/drivers/net/usb/asix_devices.c
> +++ b/drivers/net/usb/asix_devices.c
> @@ -701,6 +701,7 @@ static int ax88772_init_phy(struct usbnet *dev)
>  		return ret;
>  	}
>  
> +	phy_suspend(priv->phydev);
>  	priv->phydev->mac_managed_pm = 1;
>  
>  	phy_attached_info(priv->phydev);
> 


-- 
Florian