linux-kernel - Re: [PATCH 1/2] tracing: Simplify & fix saved

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5666edba28107559db23ba0f948c1f82@perches.com>
Date:   Thu, 01 Jul 2021 14:07:17 -0700
From:   Joe Perches <joe@...ches.com>
To:     Steven Rostedt <rostedt@...dmis.org>
Cc:     Paul Burton <paulburton@...gle.com>,
        Joel Fernandes <joelaf@...gle.com>,
        linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...hat.com>,
        stable@...r.kernel.org
Subject: Re: [PATCH 1/2] tracing: Simplify & fix saved_tgids logic

On 2021-07-01 12:51, Steven Rostedt wrote:
> On Thu, 01 Jul 2021 12:35:29 -0700
> Joe Perches <joe@...ches.com> wrote:
> 
>> C99 comments are allowed since about 5 years ago.
> 
> Really, I thought Linus hated them. Personally, I find them rather ugly
> myself. The only user of them I see in the kernel/ directory appears to
> be for RCU. But Paul's on the C/C++ committee, so perhaps he favors 
> them.
> 
> The net/ directory doesn't have any, except perhaps to comment out code
> (which I sometimes use it for that too).
> 
> The block/, arch/x86/ directories don't have them either.
> 
> I wouldn't go and change checkpatch, but I still rather avoid them,
> especially for multi line comments.
> 
>  /*
>   * When it comes to multi line comments I prefer using something
>   * that denotes a start and an end to the comment, as it makes it
>   * look like a nice clip of information.
>   */
> 
> Instead of:
> 
>   // When it comes to multi line comments I prefer using something
>   // that denotes a start and an end to the comment, as it makes it
>   // look like a nice clip of information.
> 
> Which just looks like noise. But hey, maybe that's just me because I
> find "*" as a sign of information and '//' something to ignore. ;-)

May I suggest using something other than an amber vt220?