linux-kernel - Re: [PATCH] ext4: use ext4_grp_locked_error in mb_find

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YN4wMm0w6NogVrC/@mit.edu>
Date:   Thu, 1 Jul 2021 17:14:26 -0400
From:   "Theodore Ts'o" <tytso@....edu>
To:     Lukas Czerner <lczerner@...hat.com>
Cc:     Stephen Brennan <stephen.s.brennan@...cle.com>,
        Andreas Dilger <adilger.kernel@...ger.ca>,
        linux-ext4@...r.kernel.org, linux-kernel@...r.kernel.org,
        Junxiao Bi <junxiao.bi@...cle.com>
Subject: Re: [PATCH] ext4: use ext4_grp_locked_error in mb_find_extent

On Thu, Jun 24, 2021 at 11:55:01AM +0200, Lukas Czerner wrote:
> On Wed, Jun 23, 2021 at 04:21:14PM -0700, Stephen Brennan wrote:
> > Commit 5d1b1b3f492f ("ext4: fix BUG when calling ext4_error with locked
> > block group") introduces ext4_grp_locked_error to handle unlocking a
> > group in error cases. Otherwise, there is a possibility of a sleep while
> > atomic. However, since 43c73221b3b1 ("ext4: replace BUG_ON with WARN_ON
> > in mb_find_extent()"), mb_find_extent() has contained a ext4_error()
> > call while a group spinlock is held. Replace this with
> > ext4_grp_locked_error.
> > 
> > Fixes: 43c73221b3b1 ("ext4: replace BUG_ON with WARN_ON in mb_find_extent()")
> > Cc: <stable@...r.kernel.org> # 4.14+
> > Signed-off-by: Stephen Brennan <stephen.s.brennan@...cle.com>
> > Reviewed-by: Junxiao Bi <junxiao.bi@...cle.com>
> 
> Good catch, looks good to me.
> 
> Reviewed-by: Lukas Czerner <lczerner@...hat.com>

Thanks, applied.

					- Ted