linux-kernel - Re: [PATCH v11] i2c: virtio: add a virtio i2c frontend driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YN6wlXw2KhALAyS3@kunai>
Date:   Fri, 2 Jul 2021 08:22:13 +0200
From:   Wolfram Sang <wsa@...nel.org>
To:     Viresh Kumar <viresh.kumar@...aro.org>
Cc:     Jie Deng <jie.deng@...el.com>, linux-i2c@...r.kernel.org,
        virtualization@...ts.linux-foundation.org,
        linux-kernel@...r.kernel.org, mst@...hat.com, arnd@...db.de,
        jasowang@...hat.com, andriy.shevchenko@...ux.intel.com,
        yu1.wang@...el.com, shuo.a.liu@...el.com, conghui.chen@...el.com,
        stefanha@...hat.com
Subject: Re: [PATCH v11] i2c: virtio: add a virtio i2c frontend driver


> > > Wolfram, what's expected here ? Shouldn't all message transfer or
> > > none?
> > 
> > Well, on a physical bus, it can simply happen that after message 3 of 5,
> > the bus is stalled, so we need to bail out.
> 
> Right, and in that case the transfer will have any meaning left? I believe it
> needs to be fully retried as the requests may have been dependent on each other.

The client driver handles the case. I'd assume most will bail out of the
calling function and at some higher level it will be retried.

> > Of course, it can later happen on the physical bus of the host, though,
> > that the bus is stalled after message 3 of 5, and I2C_RDWR will bail
> > out.
> 
> Basically we fail as soon as we know something is not right, correct?

Yes.


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)