linux-kernel - Re: [PATCH] objtool: avoid Memory leak: orig_alt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LSU.2.21.2107021021510.29699@pobox.suse.cz>
Date:   Fri, 2 Jul 2021 10:26:28 +0200 (CEST)
From:   Miroslav Benes <mbenes@...e.cz>
To:     gushengxian <gushengxian507419@...il.com>
cc:     jpoimboe@...hat.com, peterz@...radead.org,
        linux-kernel@...r.kernel.org, gushengxian <gushengxian@...ong.com>
Subject: Re: [PATCH] objtool: avoid Memory leak: orig_alt_group

Hi,

On Thu, 1 Jul 2021, gushengxian wrote:

> From: gushengxian <gushengxian@...ong.com>
> 
> free(orig_alt_group) should be added in order to avoid memery leak.
> Reported by cppcheck.
> 
> Signed-off-by: gushengxian <gushengxian@...ong.com>

It is not necessary. Objtool would exit immediately in case of this error 
and we do not handle the allocations in such cases. 

> ---
>  tools/objtool/check.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tools/objtool/check.c b/tools/objtool/check.c
> index e5947fbb9e7a..deb48b1bc16d 100644
> --- a/tools/objtool/check.c
> +++ b/tools/objtool/check.c
> @@ -1097,6 +1097,7 @@ static int handle_group_alt(struct objtool_file *file,
>  				     sizeof(struct cfi_state *));
>  	if (!orig_alt_group->cfi) {
>  		WARN("calloc failed");
> +		free(orig_alt_group);
>  		return -1;
>  	}

There are more sites like this in the code. For example there is one a 
couple of lines later in the same function. It is fine.

Regards
Miroslav