linux-kernel - Re: [PATCH v4 1/2] mm: introduce helper to check slub_debug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANpmjNPqHJqAaDBJDA1t-OOWKMSs5sqbwVRAkQr+E6w5EgJ1Nw@mail.gmail.com>
Date:   Fri, 2 Jul 2021 11:33:53 +0200
From:   Marco Elver <elver@...gle.com>
To:     yee.lee@...iatek.com
Cc:     andreyknvl@...il.com, wsd_upstream@...iatek.com,
        nicholas.tang@...iatek.com, Kuan-Ying.Lee@...iatek.com,
        chinwen.chang@...iatek.com, Christoph Lameter <cl@...ux.com>,
        Pekka Enberg <penberg@...nel.org>,
        David Rientjes <rientjes@...gle.com>,
        Joonsoo Kim <iamjoonsoo.kim@....com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Vlastimil Babka <vbabka@...e.cz>,
        Matthias Brugger <matthias.bgg@...il.com>,
        "open list:SLAB ALLOCATOR" <linux-mm@...ck.org>,
        open list <linux-kernel@...r.kernel.org>,
        "moderated list:ARM/Mediatek SoC support" 
        <linux-arm-kernel@...ts.infradead.org>,
        "moderated list:ARM/Mediatek SoC support" 
        <linux-mediatek@...ts.infradead.org>
Subject: Re: [PATCH v4 1/2] mm: introduce helper to check slub_debug_enabled

On Fri, 2 Jul 2021 at 10:54, <yee.lee@...iatek.com> wrote:
>
> From: Marco Elver <elver@...gle.com>
>
> Introduce a helper to check slub_debug_enabled, so that we can confine
> the use of #ifdef to the definition of the slub_debug_enabled_unlikely()
> helper.
>
> ---

^^ this '---' is wrong. It needs to be removed, because anything after
the first '---' will be discarded if it is turned into a commit by the
maintainer.


> Signed-off-by: Marco Elver <elver@...gle.com>
> Signed-off-by: Yee Lee <yee.lee@...iatek.com>
>
> ---
>  mm/slab.h | 15 +++++++++++----
>  1 file changed, 11 insertions(+), 4 deletions(-)
>
> diff --git a/mm/slab.h b/mm/slab.h
> index 7b60ef2f32c3..a11126afe24c 100644
> --- a/mm/slab.h
> +++ b/mm/slab.h
> @@ -216,10 +216,18 @@ DECLARE_STATIC_KEY_FALSE(slub_debug_enabled);
>  #endif
>  extern void print_tracking(struct kmem_cache *s, void *object);
>  long validate_slab_cache(struct kmem_cache *s);
> +static inline bool slub_debug_enabled_unlikely(void)
> +{
> +       return static_branch_unlikely(&slub_debug_enabled);
> +}
>  #else
>  static inline void print_tracking(struct kmem_cache *s, void *object)
>  {
>  }
> +static inline bool slub_debug_enabled_unlikely(void)
> +{
> +       return false;
> +}
>  #endif
>
>  /*
> @@ -229,11 +237,10 @@ static inline void print_tracking(struct kmem_cache *s, void *object)
>   */
>  static inline bool kmem_cache_debug_flags(struct kmem_cache *s, slab_flags_t flags)
>  {
> -#ifdef CONFIG_SLUB_DEBUG
> -       VM_WARN_ON_ONCE(!(flags & SLAB_DEBUG_FLAGS));
> -       if (static_branch_unlikely(&slub_debug_enabled))
> +       if (IS_ENABLED(CONFIG_SLUB_DEBUG))
> +               VM_WARN_ON_ONCE(!(flags & SLAB_DEBUG_FLAGS));
> +       if (slub_debug_enabled_unlikely())
>                 return s->flags & flags;
> -#endif
>         return false;
>  }
>
> --
> 2.18.0