linux-kernel - staging: rtl8712: dead code on flush_signals_thread call in r8712_cmd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <754d23ba-c53f-52e8-9ebd-9f1b2611cc71@canonical.com>
Date:   Fri, 2 Jul 2021 14:04:17 +0100
From:   Colin Ian King <colin.king@...onical.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Larry Finger <Larry.Finger@...inger.net>,
        Florian Schilhabel <florian.c.schilhabel@...glemail.com>
Cc:     "linux-staging@...ts.linux.dev" <linux-staging@...ts.linux.dev>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: staging: rtl8712: dead code on flush_signals_thread call in
 r8712_cmd_thread()

Hi,

Static analysis by Coverity has detected a call to
flush_signals_thread() that is never executed.  If it is removed it
won't affect the current behavior, however I'm pretty sure the call was
intentionally placed in the code at the end of a while loop so I believe
there is something a little dubious with the current code.

The analysis by Coverity is as follows:

384                        goto _next;
385                }

Structurally dead code (UNREACHABLE)
unreachable: This code cannot be reached: flush_signals_thread();.

386                flush_signals_thread();
387        }

Any ideas?

Colin