linux-kernel - Re: [PATCH] mtd: core: handle flashes without OTP gracefully

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ae770937ec2ddf12b294fbee3d815dd4@walle.cc>
Date:   Fri, 02 Jul 2021 15:53:49 +0200
From:   Michael Walle <michael@...le.cc>
To:     Guenter Roeck <linux@...ck-us.net>
Cc:     linux-mtd@...ts.infradead.org, linux-kernel@...r.kernel.org,
        Miquel Raynal <miquel.raynal@...tlin.com>,
        Richard Weinberger <richard@....at>,
        Vignesh Raghavendra <vigneshr@...com>
Subject: Re: [PATCH] mtd: core: handle flashes without OTP gracefully

Am 2021-07-02 15:49, schrieb Guenter Roeck:
> On 7/2/21 2:38 AM, Michael Walle wrote:
>> There are flash drivers which registers the OTP callbacks although the
>> flash doesn't support OTP regions and return -ENODATA for these
>> callbacks if there is no OTP. If this happens, the probe of the whole
>> flash will fail. Fix it by handling the ENODATA return code and skip
>> the OTP region nvmem setup.
>> 
>> Fixes: 4b361cfa8624 ("mtd: core: add OTP nvmem provider support")
>> Reported-by: Guenter Roeck <linux@...ck-us.net>
>> Signed-off-by: Michael Walle <michael@...le.cc>
> 
> Tested-by: Guenter Roeck <linux@...ck-us.net>

Thanks for confirming, and sorry for the inconvenience.

-michael