linux-kernel - Re: [PATCH v6 06/26] x86/fpu/xstate: Calculate and remember dynamic XSTATE buffer sizes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7B6BF36A-E1C5-4D7C-96EC-2036AE27414B@intel.com>
Date:   Fri, 2 Jul 2021 15:19:34 +0000
From:   "Bae, Chang Seok" <chang.seok.bae@...el.com>
To:     Borislav Petkov <bp@...e.de>, "Lutomirski, Andy" <luto@...nel.org>,
        "Thomas Gleixner" <tglx@...utronix.de>,
        Ingo Molnar <mingo@...nel.org>, X86 ML <x86@...nel.org>
CC:     "Brown, Len" <len.brown@...el.com>,
        "Hansen, Dave" <dave.hansen@...el.com>,
        "Liu, Jing2" <jing2.liu@...el.com>,
        "Shankar, Ravi V" <ravi.v.shankar@...el.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v6 06/26] x86/fpu/xstate: Calculate and remember dynamic
 XSTATE buffer sizes

On Jun 29, 2021, at 23:02, Bae, Chang Seok <chang.seok.bae@...el.com> wrote:
> 		/*
> 		 * The compacted-format offset always depends on where
> 		 * the previous state ended.
> 		 */
> -		paranoid_xstate_size += xfeature_size(i);
> +		xstate_size += xfeature_size(i);
> +		if (!user_dynamic)
> +			xstate_size += xfeature_size(i);

Sorry, an old patch was picked for the last line which should be:
	xstate_size_no_dynamic += xfeture_size();

Thanks,
Chang