linux-kernel - Re: [PATCH] use 64bit timer for hpet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 2 Jul 2021 23:57:05 +0800
From:   kernel test robot <lkp@...el.com>
To:     "zhaoyan.liao" <zhaoyan.liao@...ux.alibaba.com>,
        tglx@...utronix.de, mingo@...hat.com, hpa@...or.com,
        dwmw@...zon.co.uk
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org,
        kernel-janitors@...r.kernel.org, songmuchun@...edance.com,
        likunkun@...edance.com, guancheng.rjk@...baba-inc.com,
        "zhaoyan.liao" <zhaoyan.liao@...ux.alibaba.com>
Subject: Re: [PATCH] use 64bit timer for hpet

Hi "zhaoyan.liao",

Thank you for the patch! Yet something to improve:

[auto build test ERROR on tip/x86/core]
[also build test ERROR on v5.13 next-20210701]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/zhaoyan-liao/use-64bit-timer-for-hpet/20210702-161515
base:   https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git 2c88d45edbb89029c1190bb3b136d2602f057c98
config: i386-randconfig-c021-20210628 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
        # https://github.com/0day-ci/linux/commit/905ed014f601086571e608c13b14319c2f56a95c
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review zhaoyan-liao/use-64bit-timer-for-hpet/20210702-161515
        git checkout 905ed014f601086571e608c13b14319c2f56a95c
        # save the attached .config to linux build tree
        make W=1 ARCH=i386 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   arch/x86/kernel/hpet.c: In function 'hpet_readq':
>> arch/x86/kernel/hpet.c:88:9: error: implicit declaration of function 'readq'; did you mean 'readl'? [-Werror=implicit-function-declaration]
      88 |  return readq(hpet_virt_address + a);
         |         ^~~~~
         |         readl
   arch/x86/kernel/hpet.c: In function 'hpet_writeq':
>> arch/x86/kernel/hpet.c:93:2: error: implicit declaration of function 'writeq'; did you mean 'writel'? [-Werror=implicit-function-declaration]
      93 |  writeq(d, hpet_virt_address + a);
         |  ^~~~~~
         |  writel
   cc1: some warnings being treated as errors


vim +88 arch/x86/kernel/hpet.c

    85	
    86	inline unsigned long hpet_readq(unsigned int a)
    87	{
  > 88		return readq(hpet_virt_address + a);
    89	}
    90	
    91	static inline void hpet_writeq(unsigned long d, unsigned int a)
    92	{
  > 93		writeq(d, hpet_virt_address + a);
    94	}
    95	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (45040 bytes)