linux-kernel - Re: [PATCH] perf llvm: Fix error return code in llvm__compile

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 2 Jul 2021 11:01:27 +0800
From:   Zhihao Cheng <chengzhihao1@...wei.com>
To:     Arnaldo Carvalho de Melo <acme@...nel.org>
CC:     <peterz@...radead.org>, <mingo@...hat.com>, <jolsa@...hat.com>,
        <ast@...nel.org>, <daniel@...earbox.net>, <andrii@...nel.org>,
        <nathan@...nel.org>, <ndesaulniers@...gle.com>,
        <linux-perf-users@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <netdev@...r.kernel.org>, <bpf@...r.kernel.org>,
        <clang-built-linux@...glegroups.com>, <yukuai3@...wei.com>
Subject: Re: [PATCH] perf llvm: Fix error return code in llvm__compile_bpf()

在 2021/7/2 1:20, Arnaldo Carvalho de Melo 写道:
> Em Wed, Jun 09, 2021 at 07:59:45PM +0800, Zhihao Cheng escreveu:
>> Fix to return a negative error code from the error handling
>> case instead of 0, as done elsewhere in this function.
> 
> I checked and llvm__compile_bpf() returns -errno, so I'll change this to
> instead set err to -ENOMEM just before the if (asprintf)(), ok?
> 
> - Arnaldo
>   
Glad to accept this change.
>> Fixes: cb76371441d098 ("perf llvm: Allow passing options to llc ...")
>> Fixes: 5eab5a7ee032ac ("perf llvm: Display eBPF compiling command ...")
>> Reported-by: Hulk Robot <hulkci@...wei.com>
>> Signed-off-by: Zhihao Cheng <chengzhihao1@...wei.com>