linux-kernel - Re: [PATCH 2/3] mm: sparse: pass section_nr to find_memory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a03f502d-60e9-196a-0db8-88ce3a98a32c@redhat.com>
Date:   Fri, 2 Jul 2021 19:55:28 +0200
From:   David Hildenbrand <david@...hat.com>
To:     Ohhoon Kwon <ohoono.kwon@...sung.com>, akpm@...ux-foundation.org,
        mhocko@...e.com
Cc:     bhe@...hat.com, rppt@...ux.ibm.com, ohkwon1043@...il.com,
        linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] mm: sparse: pass section_nr to find_memory_block

On 02.07.21 11:41, Ohhoon Kwon wrote:
> With CONFIG_SPARSEMEM_EXTREME enabled, __section_nr() which converts
> mem_section to section_nr could be costly since it iterates all
> section roots to check if the given mem_section is in its range.
> 
> On the other hand, __nr_to_section() which converts section_nr to
> mem_section can be done in O(1).
> 
> Let's pass section_nr instead of mem_section ptr to
> find_memory_block() in order to reduce needless iterations.
> 
> Signed-off-by: Ohhoon Kwon <ohoono.kwon@...sung.com>


Reviewed-by: David Hildenbrand <david@...hat.com>

-- 
Thanks,

David / dhildenb