linux-kernel - Re: [PATCH 5.10 055/101] net: ll_temac: Add memory-barriers for TX BD access

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210703152218.GD3004@amd>
Date:   Sat, 3 Jul 2021 17:22:18 +0200
From:   Pavel Machek <pavel@...x.de>
To:     Sasha Levin <sashal@...nel.org>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Esben Haabendal <esben@...nix.com>,
        "David S . Miller" <davem@...emloft.net>
Subject: Re: [PATCH 5.10 055/101] net: ll_temac: Add memory-barriers for TX
 BD access

Hi!

> Add a couple of memory-barriers to ensure correct ordering of read/write
> access to TX BDs.

So... this is dealing with CPU-to-device consistency, not CPU-to-CPU,
right?

> +++ b/drivers/net/ethernet/xilinx/ll_temac_main.c
> @@ -774,12 +774,15 @@ static void temac_start_xmit_done(struct net_device *ndev)
>  	stat = be32_to_cpu(cur_p->app0);
>  
>  	while (stat & STS_CTRL_APP0_CMPLT) {
> +		/* Make sure that the other fields are read after bd is
> +		 * released by dma
> +		 */
> +		rmb();
>  		dma_unmap_single(ndev->dev.parent,

Full barrier, as expected.

> @@ -788,6 +791,12 @@ static void temac_start_xmit_done(struct net_device *ndev)
>  		ndev->stats.tx_packets++;
>  		ndev->stats.tx_bytes += be32_to_cpu(cur_p->len);
>  
> +		/* app0 must be visible last, as it is used to flag
> +		 * availability of the bd
> +		 */
> +		smp_mb();

SMP-only barrier, but full barrier is needed here AFAICT.

								Pavel
-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany


Download attachment "signature.asc" of type "application/pgp-signature" (182 bytes)