linux-kernel - Re: [GIT PULL] thermal for v5.14-rc1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHk-=wgZzeaZb0ByL+zPV1grizuxw2nAnmzU49S7pzV7sPS1Hg@mail.gmail.com>
Date:   Sat, 3 Jul 2021 12:34:05 -0700
From:   Linus Torvalds <torvalds@...ux-foundation.org>
To:     Daniel Lezcano <daniel.lezcano@...aro.org>
Cc:     Zhang Rui <rui.zhang@...el.com>,
        Linux PM mailing list <linux-pm@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Chunyan Zhang <zhang.chunyan@...aro.org>,
        Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>,
        Rajeshwari Ravindra Kamble <rkambl@...eaurora.org>,
        Yang Yingliang <yangyingliang@...wei.com>,
        Niklas Söderlund 
        <niklas.soderlund+renesas@...natech.se>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        Dmitry Osipenko <digetx@...il.com>,
        Ezequiel Garcia <ezequiel@...labora.com>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Yangtao Li <tiny.windzz@...il.com>,
        Finley Xiao <finley.xiao@...k-chips.com>
Subject: Re: [GIT PULL] thermal for v5.14-rc1

On Sat, Jul 3, 2021 at 9:17 AM Daniel Lezcano <daniel.lezcano@...aro.org> wrote:
>
> ssh://git@...olite.kernel.org/pub/scm/linux/kernel/git/thermal/linux.git
> tags/thermal-v5.14-rc1

This does not build for me. And I suspect it never built in linux-next either.

I get

  ERROR: modpost: "tegra_fuse_readl"
[drivers/thermal/tegra/tegra30-tsensor.ko] undefined!
  ERROR: modpost: "tegra_fuse_readl"
[drivers/thermal/tegra/tegra-soctherm.ko] undefined!
  make[1]: *** [scripts/Makefile.modpost:150: modules-only.symvers] Error 1
  make[1]: *** Deleting file 'modules-only.symvers'
  make: *** [Makefile:1762: modules] Error 2

and I think it's due to that commit 1f9c5936b10c
("thermal/drivers/tegra: Correct compile-testing of drivers") which
quite sensibly tries to extend build coverage for the tegra thermal
drivers, but that build coverage doesn't actually *work* outside the
tegra world.

That commit says "All Tegra thermal drivers support compile-testing",
but clearly they stumble at the last hurdle.

I made the decision to just unpull this, not because I couldn't fix
it, but because if it was this untested, I don't want to worry about
all the *other* code in there too.

               Linus