linux-kernel - Re: [PATCH] leds: is31fl32xx: Fix missing error code in is31fl32xx_parse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210703201924.GB6707@amd>
Date:   Sat, 3 Jul 2021 22:19:24 +0200
From:   Pavel Machek <pavel@....cz>
To:     David Rivshin <drivshin@...rd.com>
Cc:     Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>,
        linux-leds@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] leds: is31fl32xx: Fix missing error code in
 is31fl32xx_parse_dt()

On Thu 2021-06-03 17:10:10, David Rivshin wrote:
> On Tue,  1 Jun 2021 19:09:03 +0800
> Jiapeng Chong <jiapeng.chong@...ux.alibaba.com> wrote:
> 
> > The error code is missing in this code scenario, add the error code
> > '-EINVAL' to the return value 'ret'.
> > 
> > Eliminate the follow smatch warning:
> > 
> > drivers/leds/leds-is31fl32xx.c:388 is31fl32xx_parse_dt() warn: missing
> > error code 'ret'.
> > 
> > Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> > Signed-off-by: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
> 
> Good catch!
> 
> Acked-by: David Rivshin <drivshin@...worx.com>
> 
> You might also want to add a:
> 
> Fixes: 9d7cffaf99f5 ("leds: Add driver for the ISSI IS31FL32xx family of LED controllers")
>

Thanks, applied. I added the fixes tag, too, but I'm not sure if this
is suitable for stable.

Best regards,
								Pavel
-- 
http://www.livejournal.com/~pavelmachek

Download attachment "signature.asc" of type "application/pgp-signature" (182 bytes)