lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 3 Jul 2021 10:56:44 +0200 From: Oleksij Rempel <o.rempel@...gutronix.de> To: Andrew Lunn <andrew@...n.ch> Cc: '@...n.ch, Florian Fainelli <f.fainelli@...il.com>, linux-mips@...r.kernel.org, netdev@...r.kernel.org, Russell King <linux@...linux.org.uk>, "David S. Miller" <davem@...emloft.net>, Pengutronix Kernel Team <kernel@...gutronix.de>, Jakub Kicinski <kuba@...nel.org>, Vladimir Oltean <olteanv@...il.com>, Vivien Didelot <vivien.didelot@...il.com>, linux-kernel@...r.kernel.org Subject: Re: [PATCH net-next v2 3/6] net: dsa: qca: ar9331: add forwarding database support' On Fri, Jul 02, 2021 at 05:14:34PM +0200, Andrew Lunn wrote: > On Fri, Jul 02, 2021 at 12:17:48PM +0200, Oleksij Rempel wrote: > > This switch provides simple address resolution table, without VLAN or > > multicast specific information. > > With this patch we are able now to read, modify unicast and mulicast > > mul_t_icast. done > > addresses. > > +static int ar9331_sw_port_fdb_dump(struct dsa_switch *ds, int port, > > + dsa_fdb_dump_cb_t *cb, void *data) > > +{ > > + struct ar9331_sw_priv *priv = (struct ar9331_sw_priv *)ds->priv; > > + int cnt = AR9331_SW_NUM_ARL_RECORDS; > > + struct ar9331_sw_fdb _fdb = { 0 }; > > Why use _fdb? There does not appear to be an fdb? old artifact, renamed. > > +static int ar9331_sw_port_fdb_rmw(struct ar9331_sw_priv *priv, > > + const unsigned char *mac, > > + u8 port_mask_set, > > + u8 port_mask_clr) > > +{ > > + struct regmap *regmap = priv->regmap; > > + u32 f0, f1, f2 = 0; > > + u8 port_mask, port_mask_new, status, func; > > + int ret; > > Reverse Christmas tree. done > > +static int ar9331_sw_port_fdb_add(struct dsa_switch *ds, int port, > > + const unsigned char *mac, u16 vid) > > +{ > > + struct ar9331_sw_priv *priv = (struct ar9331_sw_priv *)ds->priv; > > + u16 port_mask = BIT(port); > > + > > + dev_info(priv->dev, "%s(%pM, %x)\n", __func__, mac, port); > > dev_dbg()? removed. Thank you! Can I have your Reviewed-by with this changes? Regards, Oleksij -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
Powered by blists - more mailing lists