linux-kernel - Re: [PATCH v2] tcp: fix tcp_init_transfer() to not reset icsk_ca

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f3d57ece-8fc7-f0b1-a675-32cfcd64bdda@gmail.com>
Date:   Sat, 3 Jul 2021 17:47:12 +0800
From:   Phi Nguyen <phind.uet@...il.com>
To:     Neal Cardwell <ncardwell@...gle.com>
Cc:     edumazet@...gle.com, davem@...emloft.net, yoshfuji@...ux-ipv6.org,
        dsahern@...nel.org, kuba@...nel.org, ast@...nel.org,
        daniel@...earbox.net, andrii@...nel.org, kafai@...com,
        songliubraving@...com, john.fastabend@...il.com,
        kpsingh@...nel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, bpf@...r.kernel.org,
        linux-kernel-mentees@...ts.linuxfoundation.org,
        syzbot+f1e24a0594d4e3a895d3@...kaller.appspotmail.com
Subject: Re: [PATCH v2] tcp: fix tcp_init_transfer() to not reset
 icsk_ca_initialized

On 7/3/2021 4:31 AM, Neal Cardwell wrote:
> Please note that the patchwork tools have found a style/formatting
> issue with your Fixes tag:
> 
> You can find them at:
> https://patchwork.kernel.org/project/netdevbpf/list/
>   ->
>   https://patchwork.kernel.org/project/netdevbpf/patch/20210702194033.1370634-1-phind.uet@gmail.com/
>    ->
>     https://patchwork.hopto.org/static/nipa/510221/12356435/verify_fixes/stdout
> 
> The error is:
> ---
> Fixes tag: Fixes: commit 8919a9b31eb4 ("tcp: Only init congestion control if not
> Has these problem(s):
> - leading word 'commit' unexpected
> - Subject has leading but no trailing parentheses
> - Subject has leading but no trailing quotes
> ---
> 
> Basically, please omit the "commit" and don't wrap the text (it's OK
> if it's longer than 80 or 100 characters).
> 
> thanks,
> neal
> 
Hi,

I didn't even know there are patchwork tools for checking formatting. 
Thank you for pointing out, I have just submitted a new version.

Best regards,
Phi.