linux-kernel - Re: [PATCH v2] tty: n_gsm: delete DISC command frame as requester

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 3 Jul 2021 19:42:08 +0800
From:   kernel test robot <lkp@...el.com>
To:     Zhenguo Zhao <zhenguo6858@...il.com>, gregkh@...uxfoundation.org,
        jirislaby@...nel.org
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] tty: n_gsm: delete DISC command frame as requester

Hi Zhenguo,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on tty/tty-testing]
[also build test ERROR on v5.13 next-20210701]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Zhenguo-Zhao/tty-n_gsm-delete-DISC-command-frame-as-requester/20210701-194354
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git tty-testing
config: x86_64-rhel-8.3 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
        # https://github.com/0day-ci/linux/commit/d4797539c16d71ca9d1f2b1a6959618c20a62d0d
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Zhenguo-Zhao/tty-n_gsm-delete-DISC-command-frame-as-requester/20210701-194354
        git checkout d4797539c16d71ca9d1f2b1a6959618c20a62d0d
        # save the attached .config to linux build tree
        mkdir build_dir
        make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/tty/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   drivers/tty/n_gsm.c: In function 'gsmtty_hangup':
>> drivers/tty/n_gsm.c:3047:6: error: 'gsm' undeclared (first use in this function)
    3047 |  if (gsm->initiator)
         |      ^~~
   drivers/tty/n_gsm.c:3047:6: note: each undeclared identifier is reported only once for each function it appears in


vim +/gsm +3047 drivers/tty/n_gsm.c

  3040	
  3041	static void gsmtty_hangup(struct tty_struct *tty)
  3042	{
  3043		struct gsm_dlci *dlci = tty->driver_data;
  3044		if (dlci->state == DLCI_CLOSED)
  3045			return;
  3046		tty_port_hangup(&dlci->port);
> 3047		if (gsm->initiator)
  3048			gsm_dlci_begin_close(dlci);
  3049	}
  3050	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (41440 bytes)