linux-kernel - Re: [PATCH v4.14] usb: gadget: f_fs: Fix setting of device and driver data cross-references

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YOLiDSs/9+RzMKqE@kroah.com>
Date:   Mon, 5 Jul 2021 12:42:21 +0200
From:   'Greg Kroah-Hartman' <gregkh@...uxfoundation.org>
To:     Andrew Gabbasov <andrew_gabbasov@...tor.com>
Cc:     Macpaul Lin <macpaul.lin@...iatek.com>,
        Eugeniu Rosca <erosca@...adit-jv.com>,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
        stable@...r.kernel.org, Felipe Balbi <balbi@...nel.org>,
        Eugeniu Rosca <roscaeugeniu@...il.com>,
        Eddie Hung <eddie.hung@...iatek.com>
Subject: Re: [PATCH v4.14] usb: gadget: f_fs: Fix setting of device and
 driver data cross-references

On Mon, Jul 05, 2021 at 01:24:10PM +0300, Andrew Gabbasov wrote:
> Hello Greg,
> 
> > -----Original Message-----
> > From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> > Sent: Monday, July 05, 2021 10:08 AM
> > To: Gabbasov, Andrew <Andrew_Gabbasov@...tor.com>
> > Cc: Macpaul Lin <macpaul.lin@...iatek.com>; Eugeniu Rosca <erosca@...adit-jv.com>; linux-usb@...r.kernel.org;
> > linux-kernel@...r.kernel.org; stable@...r.kernel.org; Felipe Balbi <balbi@...nel.org>; Eugeniu Rosca
> > <roscaeugeniu@...il.com>; Eddie Hung <eddie.hung@...iatek.com>
> > Subject: Re: [PATCH v4.14] usb: gadget: f_fs: Fix setting of device and driver data cross-references
> > 
> > On Fri, Jul 02, 2021 at 01:49:57PM -0500, Andrew Gabbasov wrote:
> > > Fixes: 4b187fceec3c ("usb: gadget: FunctionFS: add devices management code")
> > > Fixes: 3262ad824307 ("usb: gadget: f_fs: Stop ffs_closed NULL pointer dereference")
> > > Fixes: cdafb6d8b8da ("usb: gadget: f_fs: Fix use-after-free in ffs_free_inst")
> > > Reported-by: Bhuvanesh Surachari <bhuvanesh_surachari@...tor.com>
> > > Tested-by: Eugeniu Rosca <erosca@...adit-jv.com>
> > > Reviewed-by: Eugeniu Rosca <erosca@...adit-jv.com>
> > > Signed-off-by: Andrew Gabbasov <andrew_gabbasov@...tor.com>
> > > Link: https://lore.kernel.org/r/20210603171507.22514-1-andrew_gabbasov@mentor.com
> > > Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> > > (cherry-picked from commit ecfbd7b9054bddb12cea07fda41bb3a79a7b0149)
> > 
> > There is no such commit id in Linus's tree :(
> > 
> > Please resubmit with the correct id.
> 
> This commit is not yet included to the mainline, it only exists in linux-next:
> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=ecfbd7b9054bddb12cea07fda41bb3a79a7b0149
> 
> Could you please advise if I need to somehow denote the linux-next repo in the "cherry picked from" line,
> or just remove this line, or so far wait and re-submit the patch after the original commit is merged to Linus' tree?
> BTW, I just noticed that the line contains incorrect "cherry-picked" instead of "cherry picked",
> so I'll have to re-submit the patch anyway 😉

This is not the correct way to submit patches for inclusion in the
stable kernel tree.  Please read:
    https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.

Patches have to be in Linus's tree first before we can take it into a
stable tree.  Please feel free to resubmit this once it is in a -rc
release.

thanks,

greg k-h