linux-kernel - Re: [PATCH v6 2/2] kasan: Add memzero int for unaligned size at DEBUG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <da9034e02d0a2b5ce5fae01403a881e4d637ab16.camel@mediatek.com>
Date:   Mon, 5 Jul 2021 21:53:47 +0800
From:   Yee Lee <yee.lee@...iatek.com>
To:     Andrey Konovalov <andreyknvl@...il.com>,
        Marco Elver <elver@...gle.com>,
        Andrew Morton <akpm@...ux-foundation.org>
CC:     LKML <linux-kernel@...r.kernel.org>, <nicholas.tang@...iatek.com>,
        Kuan-Ying Lee <Kuan-Ying.Lee@...iatek.com>,
        <chinwen.chang@...iatek.com>,
        Andrey Ryabinin <ryabinin.a.a@...il.com>,
        Alexander Potapenko <glider@...gle.com>,
        Dmitry Vyukov <dvyukov@...gle.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Matthias Brugger <matthias.bgg@...il.com>,
        "open list:KASAN" <kasan-dev@...glegroups.com>,
        "open list:MEMORY MANAGEMENT" <linux-mm@...ck.org>,
        "moderated list:ARM/Mediatek SoC support" 
        <linux-arm-kernel@...ts.infradead.org>,
        "moderated list:ARM/Mediatek SoC support" 
        <linux-mediatek@...ts.infradead.org>
Subject: Re: [PATCH v6 2/2] kasan: Add memzero int for unaligned size at
 DEBUG

Thank you, Macro. I thought members in "suggested-by" would be put in
the list as well... And thank you guys for the review these days. 


@Andrew Motom
Hi Andrew, 

Could you help to push the patches? We are dealing with the issue and 
would backport to Android porject right after the action.
Appreciated!


BR,
Yee 


On Mon, 2021-07-05 at 13:23 +0200, Andrey Konovalov wrote:
> On Mon, Jul 5, 2021 at 1:18 PM Marco Elver <elver@...gle.com> wrote:
> > 
> > On Mon, 5 Jul 2021 at 13:12, Andrey Konovalov <andreyknvl@...il.com
> > > wrote:
> > [...]
> > > > +       /*
> > > > +        * Explicitly initialize the memory with the precise
> > > > object size to
> > > > +        * avoid overwriting the SLAB redzone. This disables
> > > > initialization in
> > > > +        * the arch code and may thus lead to performance
> > > > penalty. The penalty
> > > > +        * is accepted since SLAB redzones aren't enabled in
> > > > production builds.
> > > > +        */
> > > > +       if (__slub_debug_enabled() &&
> > > 
> > > What happened to slub_debug_enabled_unlikely()? Was it renamed?
> > > Why? I
> > > didn't receive patch #1 of v6 (nor of v5).
> > 
> > Somebody had the same idea with the helper:
> > https://lkml.kernel.org/r/YOKsC75kJfCZwySD@elver.google.com
> > and Matthew didn't like the _unlikely() prefix.
> > 
> > Which meant we should just move the existing helper introduced in
> > the
> > merge window.
> > 
> > Patch 1/2: 
> > https://lkml.kernel.org/r/20210705103229.8505-2-yee.lee@mediatek.com
> 
> Got it. Thank you, Marco!