linux-kernel - Re: [PATCH v2] mtd: rawnand: denali: add more delays before latching incoming data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210705144823.GA1459782@maple.netwinder.org>
Date:   Mon, 5 Jul 2021 10:48:23 -0400
From:   Ralph Siemsen <ralph.siemsen@...aro.org>
To:     Masahiro Yamada <masahiroy@...nel.org>
Cc:     linux-mtd <linux-mtd@...ts.infradead.org>,
        Marek Vasut <marex@...x.de>,
        Miquel Raynal <miquel.raynal@...tlin.com>,
        Richard Weinberger <richard@....at>,
        Vignesh Raghavendra <vigneshr@...com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] mtd: rawnand: denali: add more delays before latching
 incoming data

On Mon, Jul 05, 2021 at 01:00:43AM +0900, Masahiro Yamada wrote:
>
>I no longer have any hardware to test this driver.
>
>If you increase data_setup_on_host (the current value is 10000),
>will it solve your issue?

Yes, it does seem to work with this value increased to 10001.

Looking more closely, I compared timing parameters in struct 
denali_chip_sel, for the kernel 5.4 (which works), for 5.10 (which 
fails), and also for 5.10 with data_setup_host=10001 (which works).

                 5.4     5.10    5.10+10001
acc_clks        2       3       4
rdwr_en_lo_cnt  3       2       3
cs_setup_cnt    1       0       0

So it seems that on my hardware, rdwr_en_lo_cnt must be >= 3.

Regards,
Ralph