linux-kernel - Re: [PATCH net-next 3/3] net: hns3: add support for link diagnosis info in debugfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ce0b9907-faa7-1f54-4040-e139ae153dec@huawei.com>
Date:   Mon, 5 Jul 2021 09:12:28 +0800
From:   "huangguangbin (A)" <huangguangbin2@...wei.com>
To:     Andrew Lunn <andrew@...n.ch>
CC:     Jakub Kicinski <kuba@...nel.org>, <davem@...emloft.net>,
        <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <salil.mehta@...wei.com>, <lipeng321@...wei.com>
Subject: Re: [PATCH net-next 3/3] net: hns3: add support for link diagnosis
 info in debugfs



On 2021/7/5 3:57, Andrew Lunn wrote:
>>>> Hi Jakub, I have a question to consult you.
>>>> Some fault information in our patch are not existed in current ethtool extended
>>>> link states, for examples:
>>>> "Serdes reference clock lost"
>>>> "Serdes analog loss of signal"
>>>> "SFP tx is disabled"
>>>> "PHY power down"
>>>
>>> Why would the PHY be powered down if user requested port to be up?
>>>
>> In the case of other user may use MDIO tool to write PHY register directly to make
>> PHY power down, if link state can display this information, I think it is helpful.
> 
> If the user directly writes to PHY registers, they should expect bad
> things to happen. They can do a lot more than power the PHY down. They
> could configure it into loopback mode, turn off autoneg and force a
> mode which is compatible with the peer, etc.
> 
> I don't think you need to tell the user they have pointed a foot gun
> at their feet and pulled the trigger.
> 
>     Andrew
> .
> 
OK, I accept your point, thanks!