linux-kernel - Re: [PATCH] LICENSES/dual/CC-BY-4.0: Lets switch to utf-8

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <875yxokdd0.fsf@meer.lwn.net>
Date:   Mon, 05 Jul 2021 09:08:11 -0600
From:   Jonathan Corbet <corbet@....net>
To:     Nishanth Menon <nm@...com>,
        Thorsten Leemhuis <linux@...mhuis.info>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Thomas Gleixner <tglx@...utronix.de>
Cc:     linux-kernel@...r.kernel.org, linux-spdx@...r.kernel.org,
        Nishanth Menon <nm@...com>, Christoph Hellwig <hch@....de>,
        Rahul T R <r-ravikumar@...com>
Subject: Re: [PATCH] LICENSES/dual/CC-BY-4.0: Lets switch to utf-8

Nishanth Menon <nm@...com> writes:

> Lets drop the unicode characters that peeped in and replace with
> equivalent utf-8 characters. This makes the CC-BY-4.0 file inline with
> rest of license files.
>
> This messes up code such as scripts/spdxcheck.py which assumed utf-8
> LICENSE files.
>
> Fixes: bc41a7f36469 ("LICENSES: Add the CC-BY-4.0 license")

So...this file *is* in UTF-8; I'm finding your changelog a bit
confusing. 

> Cc: Thorsten Leemhuis <linux@...mhuis.info>
> CC: Thomas Gleixner <tglx@...utronix.de>
> CC: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> CC: Christoph Hellwig <hch@....de>
> Cc: Jonathan Corbet <corbet@....net>
>
> Reported-by: Rahul T R <r-ravikumar@...com>
> Signed-off-by: Nishanth Menon <nm@...com>
> ---
> also see: https://lore.kernel.org/linux-spdx/20210703012128.27946-1-nm@ti.com/T/#u
>
>  LICENSES/dual/CC-BY-4.0 | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/LICENSES/dual/CC-BY-4.0 b/LICENSES/dual/CC-BY-4.0
> index 45a81b8e4669..869cad3d1643 100644
> --- a/LICENSES/dual/CC-BY-4.0
> +++ b/LICENSES/dual/CC-BY-4.0
> @@ -392,7 +392,7 @@ Section 8 -- Interpretation.
>  Creative Commons is not a party to its public
>  licenses. Notwithstanding, Creative Commons may elect to apply one of
>  its public licenses to material it publishes and in those instances
> -will be considered the “Licensor.” The text of the Creative Commons
> +will be considered the "Licensor." The text of the Creative Commons

It seems that what you're really doing is replacing "smart quotes" with
the basic ASCII variety?  That seems like a fine thing to do, but that's
not really what the changelog says.

I can tweak it when I apply this.

Meanwhile, though, if there's a bug it's the spdxcheck.py issue reported
by Rahul.  That problem doesn't reproduce here; he must be running in an
environment where ASCII is assumed.  Being explicit about the encoding
expected is the right fix in any case...  Maybe I'll snag that patch as
well if nobody else beats me to it.

Thanks,

jon