linux-kernel - Re: [PATCH] MIPS: ralink: of: fix build of rt2880

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b87bbb80-ed02-447d-f778-7997848731cd@roeck-us.net>
Date:   Mon, 5 Jul 2021 09:08:41 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>,
        Wim Van Sebroeck <wim@...ux-watchdog.org>,
        Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
        Philipp Zabel <p.zabel@...gutronix.de>,
        linux-watchdog@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-mips@...r.kernel.org, John Crispin <john@...ozen.org>
Cc:     Lee Jones <lee.jones@...aro.org>, kernel test robot <lkp@...el.com>
Subject: Re: [PATCH] MIPS: ralink: of: fix build of rt2880_wdt watchdog module

On 7/5/21 8:15 AM, Krzysztof Kozlowski wrote:
> On 14/05/2021 16:04, Krzysztof Kozlowski wrote:
>> On 14/05/2021 09:48, Guenter Roeck wrote:
>>> On 5/14/21 6:17 AM, Krzysztof Kozlowski wrote:
>>>> When rt2880_wdt watchdog driver is built as a module, the
>>>> rt_sysc_membase needs to be exported (it is being used via inlined
>>>> rt_sysc_r32):
>>>>
>>>>     ERROR: modpost: "rt_sysc_membase" [drivers/watchdog/rt2880_wdt.ko] undefined!
>>>>
>>>> Reported-by: kernel test robot <lkp@...el.com>
>>>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>
>>>
>>> Acked-by: Guenter Roeck <linux@...ck-us.net>
>>>
>>> I don't see a recent change in the code. Has that problem been there
>>> all along ?
>>
>> I think the problem was there always but 0-day builder did not hit it
>> until recently:
>> https://lore.kernel.org/lkml/202105082122.yrF7ploN-lkp@intel.com/
> 
> Hi Guenter,
> 
> It seems that patch was not applied. Anything to fix here?
> 
I see commit fef532ea0cd8 ("MIPS: ralink: export rt_sysc_membase for
rt2880_wdt.c"). Does that not solve the problem ?

Guenter