linux-kernel - Re: [PATCH 2/3] PCI: tegra: Use 'seq_puts' instead of 'seq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d883403c-abe5-8f98-11eb-a70606040e0a@nvidia.com>
Date:   Mon, 5 Jul 2021 22:31:12 +0530
From:   Vidya Sagar <vidyas@...dia.com>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>,
        <thierry.reding@...il.com>, <lorenzo.pieralisi@....com>,
        <robh@...nel.org>, <bhelgaas@...gle.com>, <jonathanh@...dia.com>
CC:     <linux-tegra@...r.kernel.org>, <linux-pci@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <kernel-janitors@...r.kernel.org>
Subject: Re: [PATCH 2/3] PCI: tegra: Use 'seq_puts' instead of 'seq_printf'

Reviewed-by: Vidya Sagar <vidyas@...dia.com>

On 5/4/2021 10:47 PM, Christophe JAILLET wrote:
> As spotted by checkpatch, use 'seq_puts' instead of 'seq_printf' when
> possible.
> It is slightly more efficient.
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> ---
>   drivers/pci/controller/pci-tegra.c | 10 +++++-----
>   1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/pci/controller/pci-tegra.c b/drivers/pci/controller/pci-tegra.c
> index 006bf0346dec..fe8e21ce3e3d 100644
> --- a/drivers/pci/controller/pci-tegra.c
> +++ b/drivers/pci/controller/pci-tegra.c
> @@ -2550,7 +2550,7 @@ static void *tegra_pcie_ports_seq_start(struct seq_file *s, loff_t *pos)
>   	if (list_empty(&pcie->ports))
>   		return NULL;
>   
> -	seq_printf(s, "Index  Status\n");
> +	seq_puts(s, "Index  Status\n");
>   
>   	return seq_list_start(&pcie->ports, *pos);
>   }
> @@ -2587,16 +2587,16 @@ static int tegra_pcie_ports_seq_show(struct seq_file *s, void *v)
>   	seq_printf(s, "%2u     ", port->index);
>   
>   	if (up)
> -		seq_printf(s, "up");
> +		seq_puts(s, "up");
>   
>   	if (active) {
>   		if (up)
> -			seq_printf(s, ", ");
> +			seq_puts(s, ", ");
>   
> -		seq_printf(s, "active");
> +		seq_puts(s, "active");
>   	}
>   
> -	seq_printf(s, "\n");
> +	seq_puts(s, "\n");
>   	return 0;
>   }
>   
>