linux-kernel - Re: [PATCH 3/3] PCI: tegra: make const array err

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 6 Jul 2021 00:31:52 +0200
From:   Krzysztof Wilczyński <kw@...ux.com>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc:     thierry.reding@...il.com, lorenzo.pieralisi@....com,
        robh@...nel.org, bhelgaas@...gle.com, jonathanh@...dia.com,
        linux-tegra@...r.kernel.org, linux-pci@...r.kernel.org,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH 3/3] PCI: tegra: make const array err_msg static

Hi Christophe,

Thank you for sending the patches over and taking care about these!

I was wondering whether you will be willing to send a v2 of this series
that would include fixes to everything the checkpatch.pl script reports
against this driver?  There aren't a lot of things to fix, thus the idea
to squash everything at once.  These warnings would be as follows
(excluding the ones you taken care of in this series):

  drivers/pci/controller/pci-tegra.c:1661: WARNING: please, no space before tabs
  drivers/pci/controller/pci-tegra.c:1890: WARNING: quoted string split across lines
  drivers/pci/controller/pci-tegra.c:1891: WARNING: quoted string split across lines
  drivers/pci/controller/pci-tegra.c:2619: WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'.

These should be trivial to fix.  The two pertaining to "quoted string
split across lines" would be something that we might or might not decide
to do anything about this - technically, as per the Linux kernel coding
style [1], we ought to fix this... but, this particular case is not
a terrible example, so I will leave this at your discretion.

What do you think?

Also, don't worry if you don't have the time or otherwise, as these are
trivial things and it would only be a bonus to take care of them.

1. https://www.kernel.org/doc/html/v4.10/process/coding-style.html#breaking-long-lines-and-strings

	Krzysztof