linux-kernel - Re: [PATCH net] can: j1939: j1939_xtp_rx_dat_one(): fix rxtimer value between consecutive TP.DT to 750ms

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210706113806.tgcijzi5z7kxhiw2@pengutronix.de>
Date:   Tue, 6 Jul 2021 13:38:06 +0200
From:   Oleksij Rempel <o.rempel@...gutronix.de>
To:     Zhang Changzhong <zhangchangzhong@...wei.com>
Cc:     Robin van der Gracht <robin@...tonic.nl>,
        Oleksij Rempel <linux@...pel-privat.de>, kernel@...gutronix.de,
        Oliver Hartkopp <socketcan@...tkopp.net>,
        Marc Kleine-Budde <mkl@...gutronix.de>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Kurt Van Dijck <dev.kurt@...dijck-laurijssen.be>,
        Maxime Jayat <maxime.jayat@...ile-devices.fr>,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-can@...r.kernel.org
Subject: Re: [PATCH net] can: j1939: j1939_xtp_rx_dat_one(): fix rxtimer
 value between consecutive TP.DT to 750ms

On Tue, Jul 06, 2021 at 07:00:08PM +0800, Zhang Changzhong wrote:
> For receive side, the max time interval between two consecutive TP.DT
> should be 750ms.
> 
> Fixes: 9d71dd0c7009 ("can: add support of SAE J1939 protocol")
> Signed-off-by: Zhang Changzhong <zhangchangzhong@...wei.com>

ACK,
according to: SAE-J1939-21: T1 time is 750ms
according to: ISO 11783-3: T1 time is <=750ms

Acked-by: Oleksij Rempel <o.rempel@...gutronix.de>

> ---
>  net/can/j1939/transport.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/can/j1939/transport.c b/net/can/j1939/transport.c
> index c3946c3..4113229 100644
> --- a/net/can/j1939/transport.c
> +++ b/net/can/j1939/transport.c
> @@ -1869,7 +1869,7 @@ static void j1939_xtp_rx_dat_one(struct j1939_session *session,
>  		if (!session->transmission)
>  			j1939_tp_schedule_txtimer(session, 0);
>  	} else {
> -		j1939_tp_set_rxtimeout(session, 250);
> +		j1939_tp_set_rxtimeout(session, 750);
>  	}
>  	session->last_cmd = 0xff;
>  	consume_skb(se_skb);
> -- 
> 2.9.5
> 
> 
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |