linux-kernel - Re: [sparc64] locking/atomic, kernel OOPS on running stress-ng

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210706120030.GB69200@C02TD0UTHF1T.local>
Date:   Tue, 6 Jul 2021 13:00:30 +0100
From:   Mark Rutland <mark.rutland@....com>
To:     Anatoly Pugachev <matorola@...il.com>,
        Peter Zijlstra <peterz@...ts.infradead.org>
Cc:     Linux Kernel list <linux-kernel@...r.kernel.org>,
        Sparc kernel list <sparclinux@...r.kernel.org>,
        debian-sparc <debian-sparc@...ts.debian.org>
Subject: Re: [sparc64] locking/atomic, kernel OOPS on running stress-ng

On Tue, Jul 06, 2021 at 02:51:06PM +0300, Anatoly Pugachev wrote:
> On Tue, Jul 6, 2021 at 12:11 PM Mark Rutland <mark.rutland@....com> wrote:
> > Fixes: ff5b4f1ed580c59d ("locking/atomic: sparc: move to ARCH_ATOMIC")
> > Signed-off-by: Mark Rutland <mark.rutland@....com>
> > Reported-by: Anatoly Pugachev <matorola@...il.com>
> > Cc: "David S. Miller" <davem@...emloft.net>
> > Cc: Peter Zijlstra <peterz@...ts.infradead.org>
> > ---
> >  arch/sparc/include/asm/cmpxchg_64.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/sparc/include/asm/cmpxchg_64.h b/arch/sparc/include/asm/cmpxchg_64.h
> > index 8c39a9981187..12d00a42c0a3 100644
> > --- a/arch/sparc/include/asm/cmpxchg_64.h
> > +++ b/arch/sparc/include/asm/cmpxchg_64.h
> > @@ -201,7 +201,7 @@ static inline unsigned long __cmpxchg_local(volatile void *ptr,
> >  #define arch_cmpxchg64_local(ptr, o, n)                                        \
> >    ({                                                                   \
> >         BUILD_BUG_ON(sizeof(*(ptr)) != 8);                              \
> > -       cmpxchg_local((ptr), (o), (n));                                 \
> > +       arch_cmpxchg_local((ptr), (o), (n));                                    \
> >    })
> >  #define arch_cmpxchg64(ptr, o, n)      arch_cmpxchg64_local((ptr), (o), (n))
> 
> 
> Mark, thanks, fixed...
> tested on git kernel 5.13.0-11788-g79160a603bdb-dirty (dirty - cause
> patch has been applied).

Great! Thanks for confirming.

Peter, are you happy to pick that (full commit in last mail), or should
I send a new copy?

Thanks,
Mark.