linux-kernel - RE: [PATCH V3 0/4] tools: perf: Add JSON metrics for i.MX8M platforms

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DB8PR04MB67958BF70501FB79BFC6F786E61B9@DB8PR04MB6795.eurprd04.prod.outlook.com>
Date:   Tue, 6 Jul 2021 12:28:05 +0000
From:   Joakim Zhang <qiangqing.zhang@....com>
To:     John Garry <john.garry@...wei.com>,
        "will@...nel.org" <will@...nel.org>,
        "mathieu.poirier@...aro.org" <mathieu.poirier@...aro.org>,
        "leo.yan@...aro.org" <leo.yan@...aro.org>,
        "peterz@...radead.org" <peterz@...radead.org>,
        "mingo@...hat.com" <mingo@...hat.com>,
        "acme@...nel.org" <acme@...nel.org>,
        "mark.rutland@....com" <mark.rutland@....com>,
        "alexander.shishkin@...ux.intel.com" 
        <alexander.shishkin@...ux.intel.com>,
        "jolsa@...hat.com" <jolsa@...hat.com>,
        "namhyung@...nel.org" <namhyung@...nel.org>,
        "shawnguo@...nel.org" <shawnguo@...nel.org>,
        "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>
CC:     "kernel@...gutronix.de" <kernel@...gutronix.de>,
        "festevam@...il.com" <festevam@...il.com>,
        dl-linux-imx <linux-imx@....com>,
        "kjain@...ux.ibm.com" <kjain@...ux.ibm.com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH V3 0/4] tools: perf: Add JSON metrics for i.MX8M platforms


> -----Original Message-----
> From: John Garry <john.garry@...wei.com>
> Sent: 2021年7月6日 18:06
> To: Joakim Zhang <qiangqing.zhang@....com>; will@...nel.org;
> mathieu.poirier@...aro.org; leo.yan@...aro.org; peterz@...radead.org;
> mingo@...hat.com; acme@...nel.org; mark.rutland@....com;
> alexander.shishkin@...ux.intel.com; jolsa@...hat.com;
> namhyung@...nel.org; shawnguo@...nel.org; s.hauer@...gutronix.de
> Cc: kernel@...gutronix.de; festevam@...il.com; dl-linux-imx
> <linux-imx@....com>; kjain@...ux.ibm.com;
> linux-arm-kernel@...ts.infradead.org; linux-kernel@...r.kernel.org
> Subject: Re: [PATCH V3 0/4] tools: perf: Add JSON metrics for i.MX8M
> platforms
> 
> On 06/07/2021 10:48, Joakim Zhang wrote:
> >> Hi Joakim,
> >>
> >> I have done some rework to the metricgroup sys event support.
> >>
> >> If you have a chance, it would be appreciated if you could test this
> >> following series for these imx8 metrics+events:
> >>
> >> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit
> >> hub.c
> >> om%2Fhisilicon%2Fkernel-dev%2Fcommits%2Fprivate-topic-perf-5.13-sys-r
> >> ewri
> >>
> te-3&amp;data=04%7C01%7Cqiangqing.zhang%40nxp.com%7Cbf35517133c3
> >>
> 48ebd58e08d940587875%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0
> >> %7C637611570992762798%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4w
> LjA
> >>
> wMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;s
> >>
> data=RzNaXZubTrhO0MRl2sD45v7Vbs1KgzRWCRymTQIJLZM%3D&amp;reser
> >> ved=0
> > Hi John,
> >
> > I only need build perf tool with above code, no need to update the kernel,
> right?
> 
> Right, just userspace perf tool needs rebuild. Same kernel which you used
> before should be ok.

Hi John,

Test env:
perf version 5.13.rc7.gf9a8701c7091
5.13.0-rc1-next-20210514

I tested on i.MX8MQ, i.MX8MM and i.MX8MP, there is no function breakage, but I have not verified metric includes "duration_time" event.

A nitpick, there is no comma at the end of "Unit".

Best Regards,
Joakim Zhang
> 
> Thanks!