linux-kernel - Re: [PATCH][next] ksmbd: Fix read on the uninitialized pointer sess

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAKYAXd9=fQv2jqSUkeavnccvTd8n5ShpCW=jFC5ikx_=Bo=G3A@mail.gmail.com>
Date:   Tue, 6 Jul 2021 21:43:58 +0900
From:   Namjae Jeon <linkinjeon@...nel.org>
To:     Colin King <colin.king@...onical.com>
Cc:     Namjae Jeon <namjae.jeon@...sung.com>,
        Sergey Senozhatsky <senozhatsky@...omium.org>,
        Steve French <sfrench@...ba.org>,
        Hyunchul Lee <hyc.lee@...il.com>, linux-cifs@...r.kernel.org,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH][next] ksmbd: Fix read on the uninitialized pointer sess

Hi Colin,

2021-07-06 21:05 GMT+09:00, Colin King <colin.king@...onical.com>:
> From: Colin Ian King <colin.king@...onical.com>
>
> There is a error handling case that passes control to label out_err
> without pointer sess being assigned a value. The unassigned pointer
> may be any garbage value and so the test of rc < 0 && sess maybe
> true leading to sess being passed to the call to ksmbd_session_destroy.
> Fix this by setting sess to NULL in this corner case.
>
> Addresses-Coverity: ("Uninitialized pointer read")
> Fixes: f5a544e3bab7 ("ksmbd: add support for SMB3 multichannel")
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
I will apply this patch. Thanks for your patch!