linux-kernel - Re: [PATCH v3] ARM: dts: imx7d-remarkable2: Add WiFi support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 6 Jul 2021 09:29:19 -0300
From:   Fabio Estevam <festevam@...il.com>
To:     Alistair Francis <alistair@...stair23.me>
Cc:     Rob Herring <robh+dt@...nel.org>, Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Sascha Hauer <kernel@...gutronix.de>,
        NXP Linux Team <linux-imx@....com>,
        "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" 
        <linux-arm-kernel@...ts.infradead.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>, alistair23@...il.com
Subject: Re: [PATCH v3] ARM: dts: imx7d-remarkable2: Add WiFi support

Hi Alistair,

On Tue, Jul 6, 2021 at 8:40 AM Alistair Francis <alistair@...stair23.me> wrote:

> +       wifi_pwrseq: wifi_pwrseq {
> +               compatible = "mmc-pwrseq-simple";
> +               pinctrl-names = "default";
> +               pinctrl-0 = <&pinctrl_wifi>;
> +               reset-gpios = <&gpio5 9 GPIO_ACTIVE_LOW>;
> +               clocks = <&clks IMX7D_CLKO2_ROOT_DIV>;

Don't you need to select the osc32 as the parent clock?

This is what we do on arch/arm/boot/dts/imx7d-pico.dtsi and
arch/arm/boot/dts/imx7d-nitrogen7.dts:

&clks {
assigned-clocks = <&clks IMX7D_CLKO2_ROOT_SRC>,
  <&clks IMX7D_CLKO2_ROOT_DIV>;
assigned-clock-parents = <&clks IMX7D_CKIL>;
assigned-clock-rates = <0>, <32768>;
};