linux-kernel - Re: [PATCH] bus: Make remove callback return void

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <22817b58fe78a803af3440b7571922289fdb87f8.camel@igalia.com>
Date:   Tue, 06 Jul 2021 14:50:40 +0200
From:   Samuel Iglesias Gonsálvez 
        <siglesias@...lia.com>
To:     Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
        Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        kernel@...gutronix.de, linux-kernel@...r.kernel.org,
        Russell King <linux@...linux.org.uk>,
        Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
        "James E.J. Bottomley" <James.Bottomley@...senpartnership.com>,
        Helge Deller <deller@....de>,
        Geoff Levand <geoff@...radead.org>,
        Michael Ellerman <mpe@...erman.id.au>,
        Benjamin Herrenschmidt <benh@...nel.crashing.org>,
        Paul Mackerras <paulus@...ba.org>,
        "Rafael J. Wysocki" <rjw@...ysocki.net>,
        Len Brown <lenb@...nel.org>,
        William Breathitt Gray <vilhelm.gray@...il.com>,
        Rafał Miłecki <zajec5@...il.com>,
        Maxime Ripard <mripard@...nel.org>,
        Chen-Yu Tsai <wens@...e.org>,
        Jernej Skrabec <jernej.skrabec@...il.com>,
        Alison Schofield <alison.schofield@...el.com>,
        Vishal Verma <vishal.l.verma@...el.com>,
        Ira Weiny <ira.weiny@...el.com>,
        Ben Widawsky <ben.widawsky@...el.com>,
        Dan Williams <dan.j.williams@...el.com>,
        Dave Jiang <dave.jiang@...el.com>,
        Vinod Koul <vkoul@...nel.org>,
        Stefan Richter <stefanr@...6.in-berlin.de>,
        Sudeep Holla <sudeep.holla@....com>,
        Cristian Marussi <cristian.marussi@....com>,
        Wu Hao <hao.wu@...el.com>, Tom Rix <trix@...hat.com>,
        Moritz Fischer <mdf@...nel.org>,
        Jiri Kosina <jikos@...nel.org>,
        Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>,
        "K. Y. Srinivasan" <kys@...rosoft.com>,
        Haiyang Zhang <haiyangz@...rosoft.com>,
        Stephen Hemminger <sthemmin@...rosoft.com>,
        Wei Liu <wei.liu@...nel.org>, Dexuan Cui <decui@...rosoft.com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Wolfram Sang <wsa@...nel.org>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Jens Taprogge <jens.taprogge@...rogge.org>,
        Johannes Thumshirn <morbidrsa@...il.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Maxim Levitsky <maximlevitsky@...il.com>, Alex Dubov <oakad@ya>
Subject: Re: [PATCH] bus: Make remove callback return void

On Tue, 2021-07-06 at 14:41 +0300, Heikki Krogerus wrote:
> On Tue, Jul 06, 2021 at 11:50:37AM +0200, Uwe Kleine-König wrote:
> > The driver core ignores the return value of this callback because
> > there
> > is only little it can do when a device disappears.
> > 
> > This is the final bit of a long lasting cleanup quest where several
> > buses were converted to also return void from their remove callback.
> > Additionally some resource leaks were fixed that were caused by
> > drivers
> > returning an error code in the expectation that the driver won't go
> > away.
> > 
> > With struct bus_type::remove returning void it's prevented that newly
> > implemented buses return an ignored error code and so don't
> > anticipate
> > wrong expectations for driver authors.
> > 
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> 

For ipack changes:

Acked-by: Samuel Iglesias Gonsálvez <siglesias@...lia.com>

Thanks,

Sam

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)