linux-kernel - Re: [PATCH 2/2] vringh: Include spinlock.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210706144425.cp3yzdinmosqftjr@steredhat>
Date:   Tue, 6 Jul 2021 16:44:25 +0200
From:   Stefano Garzarella <sgarzare@...hat.com>
To:     Eugenio Pérez <eperezma@...hat.com>
Cc:     mst@...hat.com, linux-kernel@...r.kernel.org,
        Matthew Wilcox <willy@...radead.org>,
        Jason Wang <jasowang@...hat.com>,
        Yunsheng Lin <linyunsheng@...wei.com>
Subject: Re: [PATCH 2/2] vringh: Include spinlock.h

On Tue, Jul 06, 2021 at 04:26:32PM +0200, Eugenio Pérez wrote:
>Commit f53d9910d009 ("vringh: add 'iotlb_lock' to synchronize iotlb
>accesses") introduces this dependency, but does not include spinlock.h.
>While kernel seems to compile as usual, tools/virtio cannot do the
>same.
>
>Fixes: f53d9910d009 ("vringh: add 'iotlb_lock' to synchronize iotlb accesses")
>
>Signed-off-by: Eugenio Pérez <eperezma@...hat.com>
>---
> include/linux/vringh.h | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/include/linux/vringh.h b/include/linux/vringh.h
>index 84db7b8f912f..212892cf9822 100644
>--- a/include/linux/vringh.h
>+++ b/include/linux/vringh.h
>@@ -14,6 +14,7 @@
> #include <linux/virtio_byteorder.h>
> #include <linux/uio.h>
> #include <linux/slab.h>
>+#include <linux/spinlock.h>
> #if IS_REACHABLE(CONFIG_VHOST_IOTLB)
> #include <linux/dma-direction.h>
> #include <linux/vhost_iotlb.h>
>-- 
>2.27.0
>

Ooops, thanks for fixing this!

Reviewed-by: Stefano Garzarella <sgarzare@...hat.com>