linux-kernel - Re: [PATCH 0/4] FPGA Manager address unused variable warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 6 Jul 2021 09:28:37 -0700
From:   Tom Rix <trix@...hat.com>
To:     Moritz Fischer <mdf@...nel.org>, linux-fpga@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/4] FPGA Manager address unused variable warnings


On 7/1/21 8:54 PM, Moritz Fischer wrote:
> This patchset addresses a handful of warnings as result of_match_ids
> being not properly wrapped in #ifdef CONFIG_OF.
>
> Moritz Fischer (4):
>    fpga: altera-freeze-bridge: Address warning about unused variable
>    fpga: xiilnx-spi: Address warning about unused variable
>    fpga: xilinx-pr-decoupler: Address warning about unused variable
>    fpga: zynqmp-fpga: Address warning about unused variable
>
>   drivers/fpga/altera-freeze-bridge.c | 2 ++
>   drivers/fpga/xilinx-pr-decoupler.c  | 2 ++
>   drivers/fpga/xilinx-spi.c           | 2 ++
>   drivers/fpga/zynqmp-fpga.c          | 3 ++-
>   4 files changed, 8 insertions(+), 1 deletion(-)

I am not seeing these warnings, but it is still worth doing.

I think a few more files need this change.

altera-ps-spi.c, dfl-n3000-nios.c, altera-hps2fpga.c, stratix10-soc.c, 
socfpga-a10.c, altera-fpga2sdram.c

Not needed for

altera-pr-ip-core-plat.c and ice40-spi.c

These have depends on OF in Kconfig.

Tom