linux-kernel - Re: [PATCH] ext4: Fix comments and spaces to follow coding style

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YOSs9Qu1YpvPAP6v@mit.edu>
Date:   Tue, 6 Jul 2021 15:20:21 -0400
From:   "Theodore Ts'o" <tytso@....edu>
To:     Jan Gruber <j4n6ru@...il.com>
Cc:     adilger.kernel@...ger.ca, trivial@...nel.org,
        linux-ext4@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ext4: Fix comments and spaces to follow coding style

On Tue, Jul 06, 2021 at 08:39:00PM +0200, Jan Gruber wrote:
> This commit addresses two whitespace issues as well as
> instances of the following coding style issue regarding
> block comments, which were identified by checkpatch.pl:
> 
> "WARNING: Block comments use a trailing */ on a separate line"
> 
> The changes aim at making the code more pleasant to read
> and to eliminate warnings
> 
> Signed-off-by: Jan Gruber <j4n6ru@...il.com>

Please don't send "checkpatch.pl --file" patches for the ext4 file
system; if you must, please focus on files in the drivers directory,
where they are more welcome.  If developers are making changes to a
file, fixing some checkpatch.pl whines is fine, but white-sapace only
changes just obfuscates "git blame" code archology, and so the costs
far outwieghs the costs.  "Fix" is also not the right verb to use.
For more information please see [1].

[1] https://gist.github.com/17twenty/8154928

If you are looking for subtantive ways of contributing to the ext4
file system, feel free to look at various syzbot warnings[2] and try
to figure out what is going on there.

[2] https://syzkaller.appspot.com/upstream

(In some cases, the syzbot complaint has already been fixed, and it's
just a matter of letting syzbot knoww that it has since been fixed by
a particular commit.  See [3] for more details.)

[3] https://github.com/google/syzkaller/blob/master/docs/syzbot.md

Cheers,

						- Ted