[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20210706161432.7196c6b4@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date: Tue, 6 Jul 2021 16:14:32 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Guangbin Huang <huangguangbin2@...wei.com>
Cc: <davem@...emloft.net>, <jiri@...dia.com>, <netdev@...r.kernel.org>,
<linux-kernel@...r.kernel.org>, <lipeng321@...wei.com>,
<chenhao288@...ilicon.com>
Subject: Re: [RFC PATCH net-next 3/8] net: hns3: add support for devlink get
info for PF
On Tue, 6 Jul 2021 14:41:27 +0800 Guangbin Huang wrote:
> + return devlink_info_version_running_put(req, "fw-version", version_str);
Please use one of the existing names instead of "fw-version",
e.g. DEVLINK_INFO_VERSION_GENERIC_FW.
Powered by blists - more mailing lists