linux-kernel - Re: [PATCH 0/3] mmc: core: Avoid hogging the CPU while polling for busy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8d310df9-2139-e5ff-e0ee-205ffc1778a2@rock-chips.com>
Date:   Tue, 6 Jul 2021 15:05:15 +0800
From:   Shawn Lin <shawn.lin@...k-chips.com>
To:     Ulf Hansson <ulf.hansson@...aro.org>
Cc:     shawn.lin@...k-chips.com, Adrian Hunter <adrian.hunter@...el.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        Wolfram Sang <wsa+renesas@...g-engineering.com>,
        Christian Lohle <CLoehle@...erstone.com>,
        linux-kernel@...r.kernel.org, linux-mmc@...r.kernel.org
Subject: Re: [PATCH 0/3] mmc: core: Avoid hogging the CPU while polling for
 busy

On 2021/7/2 21:42, Ulf Hansson wrote:
> Step by step, code that have been dealing sending CMD13 to poll the card for
> busy, have been moved to use the common mmc_poll_for_busy() loop. This helps to
> avoid hogging the CPU, for example, as it inserts a small delay in between each
> polling attempt. Additionally, it avoids open coding.
> 
> This series takes the next and final step, by moving the mmc block device layer
> from its own busy polling loop, into using the common code.
> 
> Please test and review!

Hi Ulf,

This patch-set looks good,

Reviewed-by: Shawn Lin <shawn.lin@...k-chips.com>

> 
> Kind regards
> Uffe
> 
> Ulf Hansson (3):
>    mmc: core: Avoid hogging the CPU while polling for busy in the I/O err
>      path
>    mmc: core: Avoid hogging the CPU while polling for busy for mmc ioctls
>    mmc: core: Avoid hogging the CPU while polling for busy after I/O
>      writes
> 
>   drivers/mmc/core/block.c   | 74 +++++++++++++++++---------------------
>   drivers/mmc/core/mmc_ops.c |  5 ++-
>   drivers/mmc/core/mmc_ops.h |  1 +
>   3 files changed, 37 insertions(+), 43 deletions(-)
>