linux-kernel - Re: [PATCH] math: Make RATIONAL tristate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMuHMdWeRyK3iq7DNaw81OJvT6YwX8Eem1nrYfV9DzX10Xcomw@mail.gmail.com>
Date:   Tue, 6 Jul 2021 09:14:35 +0200
From:   Geert Uytterhoeven <geert@...ux-m68k.org>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     Trent Piepho <tpiepho@...il.com>,
        Colin Ian King <colin.king@...onical.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Brendan Higgins <brendanhiggins@...gle.com>,
        "open list:KERNEL SELFTEST FRAMEWORK" 
        <linux-kselftest@...r.kernel.org>, kunit-dev@...glegroups.com,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] math: Make RATIONAL tristate

Hi Andy,

On Mon, Jul 5, 2021 at 4:53 PM Andy Shevchenko
<andriy.shevchenko@...ux.intel.com> wrote:
> On Mon, Jul 05, 2021 at 01:46:33PM +0200, Geert Uytterhoeven wrote:
> > All but one symbols that select RATIONAL are tristate, but RATIONAL
> > itself is bool.  Change it to tristate, so the rational fractions
> > support code can be modular if no builtin code relies on it.
> >
> > While at it, add support for compile-testing and provide a help text.
>
> ...
>
> > Exposed by commit b6c75c4afceb8bc0 ("lib/math/rational: add Kunit test
> > cases") and CONFIG_KUNIT_ALL_TESTS=m.
> >
> > I'm not so happy RATIONAL_KUNIT_TEST selects RATIONAL, as test code
> > should depend on the presence of the feature to test.  Else enabling
> > a test may add unneeded code to a production kernel.
> > Perhaps the "if COMPILE_TEST" should be dropped, making RATIONAL
> > visible, so RATIONAL_KUNIT_TEST can depend on RATIONAL instead?
>
> ...
>
> > +     tristate "Rational fractions support" if COMPILE_TEST
>
> Making it tristate is okay, but visible (even for COMPILE_TEST)... why?
> Just on purpose to be dependent on for test case? I understand your
> justification above, but it will bring all hidden symbols to be unhidden
> (due to test cases) and this is not the right thing to do in my opinion.

OK.  Will drop in v2.

> Why not to complain to KUnit people to fix their infra to avoid tests that
> tries non-selected feature(s)?

I guess the audience is listening...

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds