linux-kernel - [PATCH] PM: domains: not update genpd status when power on fail

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Tue,  6 Jul 2021 18:05:19 +0800
From:   peng.fan@....nxp.com
To:     rjw@...ysocki.net, khilman@...nel.org, ulf.hansson@...aro.org,
        pavel@....cz, len.brown@...el.com, linux-pm@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org, Peng Fan <peng.fan@....com>
Subject: [PATCH] PM: domains: not update genpd status when power on fail

From: Peng Fan <peng.fan@....com>

When _genpd_power_on fail, the generic power domain status
should not be changed to GENPD_STATE_ON.

Signed-off-by: Peng Fan <peng.fan@....com>
---
 drivers/base/power/domain.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c
index ab0b740cc0f1..754a5d384479 100644
--- a/drivers/base/power/domain.c
+++ b/drivers/base/power/domain.c
@@ -1101,6 +1101,7 @@ static void genpd_sync_power_on(struct generic_pm_domain *genpd, bool use_lock,
 				unsigned int depth)
 {
 	struct gpd_link *link;
+	int ret;
 
 	if (genpd_status_on(genpd))
 		return;
@@ -1117,8 +1118,9 @@ static void genpd_sync_power_on(struct generic_pm_domain *genpd, bool use_lock,
 			genpd_unlock(link->parent);
 	}
 
-	_genpd_power_on(genpd, false);
-	genpd->status = GENPD_STATE_ON;
+	ret = _genpd_power_on(genpd, false);
+	if (!ret)
+		genpd->status = GENPD_STATE_ON;
 }
 
 /**
-- 
2.30.0