linux-kernel - Re: [v12 02/20] dt-bindings: ARM: Mediatek: Add mmsys document binding for MT8192

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <50ff125023425b58ba86eb50df51c34cea5ab7d8.camel@mediatek.com>
Date:   Tue, 6 Jul 2021 10:05:57 +0800
From:   Chun-Jie Chen <chun-jie.chen@...iatek.com>
To:     Matthias Brugger <matthias.bgg@...il.com>,
        Stephen Boyd <sboyd@...nel.org>,
        Nicolas Boichat <drinkcat@...omium.org>,
        Rob Herring <robh+dt@...nel.org>
CC:     <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>,
        <linux-mediatek@...ts.infradead.org>, <linux-clk@...r.kernel.org>,
        <devicetree@...r.kernel.org>, <srv_heupstream@...iatek.com>,
        <Project_Global_Chrome_Upstream_Group@...iatek.com>
Subject: Re: [v12 02/20] dt-bindings: ARM: Mediatek: Add mmsys document
 binding for MT8192

On Mon, 2021-07-05 at 17:45 +0200, Matthias Brugger wrote:
> On 05/07/2021 17:40, Matthias Brugger wrote:
> > 
> > 
> > On 05/07/2021 05:38, Chun-Jie Chen wrote:
> > > This patch adds the mmsys document binding for MT8192 SoC.
> > > 
> > > Signed-off-by: Chun-Jie Chen <chun-jie.chen@...iatek.com>
> > 
> > Reviewed-by: Matthias Brugger <matthias.bgg@...il.com>
> > 
> 
> Of course, that's not what we need here...
> 
> Now pushed to v5.14-tmp/dts64 until v5.14-rc1 is released.
> 
> Thanks!
> Matthias
> 

I see some discussion in [1] and check the implement of afe
driver(soc/mediatek/mt8192/mt8192-afe-pcm.c)
The audsys shoud be documented in mediatek,audsys.txt
I will send v13 to apply it and update dts [2],
sorry for the inconvenience.

[1]
https://patchwork.kernel.org/project/linux-mediatek/patch/20210630180652.1.I88a52644e47e88b15f5db9841cb084dc53c5875c@changeid/
[2]
https://patchwork.kernel.org/project/linux-mediatek/cover/20210616011551.29654-1-chun-jie.chen@mediatek.com/

Best Regards,
Chun-Jie
> > > ---
> > >  .../devicetree/bindings/arm/mediatek/mediatek,mmsys.txt         
> > >  | 1 +
> > >  1 file changed, 1 insertion(+)
> > > 
> > > diff --git
> > > a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.t
> > > xt
> > > b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.t
> > > xt
> > > index 78c50733985c..9712a6831fab 100644
> > > ---
> > > a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.t
> > > xt
> > > +++
> > > b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.t
> > > xt
> > > @@ -16,6 +16,7 @@ Required Properties:
> > >  	- "mediatek,mt8167-mmsys", "syscon"
> > >  	- "mediatek,mt8173-mmsys", "syscon"
> > >  	- "mediatek,mt8183-mmsys", "syscon"
> > > +	- "mediatek,mt8192-mmsys", "syscon"
> > >  - #clock-cells: Must be 1
> > >  
> > >  For the clock control, the mmsys controller uses the common clk
> > > binding from
> > > 
> 
>