linux-kernel - Re: [PATCH v2 -next] riscv: mm: fix build errors caused by mk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <mhng-baa33662-8457-4b94-8307-87f326fefe36@palmerdabbelt-glaptop>
Date:   Mon, 05 Jul 2021 19:50:54 -0700 (PDT)
From:   Palmer Dabbelt <palmer@...belt.com>
To:     sunnanyong@...wei.com
CC:     Paul Walmsley <paul.walmsley@...ive.com>, aou@...s.berkeley.edu,
        linux-riscv@...ts.infradead.org, linux-kernel@...r.kernel.org,
        Atish Patra <Atish.Patra@....com>, wangkefeng.wang@...wei.com,
        sunnanyong@...wei.com
Subject:     Re: [PATCH v2 -next] riscv: mm: fix build errors caused by mk_pmd()

On Thu, 17 Jun 2021 02:58:31 PDT (-0700), sunnanyong@...wei.com wrote:
> With "riscv: mm: add THP support on 64-bit", mk_pmd() function
> introduce build errors,
> 1.build with CONFIG_ARCH_RV32I=y:
> arch/riscv/include/asm/pgtable.h: In function 'mk_pmd':
> arch/riscv/include/asm/pgtable.h:513:9: error: implicit declaration of function 'pfn_pmd';
>  did you mean 'pfn_pgd'? [-Werror=implicit-function-declaration]
>
> 2.build with CONFIG_SPARSEMEM=y && CONFIG_SPARSEMEM_VMEMMAP=n
> arch/riscv/include/asm/pgtable.h: In function 'mk_pmd':
> include/asm-generic/memory_model.h:64:14: error: implicit declaration of function 'page_to_section';
>  did you mean 'present_section'? [-Werror=implicit-function-declaration]
>
> Move the definition of mk_pmd to pgtable-64.h to fix the first error.
> Use macro definition instead of inline function for mk_pmd
> to fix the second problem. It is similar to the mk_pte macro.
>
> Reported-by: kernel test robot <lkp@...el.com>
> Signed-off-by: Nanyong Sun <sunnanyong@...wei.com>
> ---
> Changes in v2:
> - Move mk_pmd to pgtable-64.h
> ---
>  arch/riscv/include/asm/pgtable-64.h | 2 ++
>  arch/riscv/include/asm/pgtable.h    | 5 -----
>  2 files changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/arch/riscv/include/asm/pgtable-64.h b/arch/riscv/include/asm/pgtable-64.h
> index 1439017b16f8..228261aa9628 100644
> --- a/arch/riscv/include/asm/pgtable-64.h
> +++ b/arch/riscv/include/asm/pgtable-64.h
> @@ -79,6 +79,8 @@ static inline unsigned long _pmd_pfn(pmd_t pmd)
>  	return pmd_val(pmd) >> _PAGE_PFN_SHIFT;
>  }
>
> +#define mk_pmd(page, prot)    pfn_pmd(page_to_pfn(page), prot)
> +
>  #define pmd_ERROR(e) \
>  	pr_err("%s:%d: bad pmd %016lx.\n", __FILE__, __LINE__, pmd_val(e))
>
> diff --git a/arch/riscv/include/asm/pgtable.h b/arch/riscv/include/asm/pgtable.h
> index 5ae51e6bd5ab..6bc2582f82e9 100644
> --- a/arch/riscv/include/asm/pgtable.h
> +++ b/arch/riscv/include/asm/pgtable.h
> @@ -516,11 +516,6 @@ static inline unsigned long pmd_pfn(pmd_t pmd)
>  	return ((__pmd_to_phys(pmd) & PMD_MASK) >> PAGE_SHIFT);
>  }
>
> -static inline pmd_t mk_pmd(struct page *page, pgprot_t prot)
> -{
> -	return pfn_pmd(page_to_pfn(page), prot);
> -}
> -
>  static inline pmd_t pmd_modify(pmd_t pmd, pgprot_t newprot)
>  {
>  	return pte_pmd(pte_modify(pmd_pte(pmd), newprot));

Thanks, this is on for-next.